Update excluded_ajax_paths for sf4 #26177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Feb 14, 2018
| @@ -38,7 +38,7 @@ public function getConfigTreeBuilder() | |||
| ->children() | |||
| ->booleanNode('toolbar')->defaultFalse()->end() | |||
| ->booleanNode('intercept_redirects')->defaultFalse()->end() | |||
| ->scalarNode('excluded_ajax_paths')->defaultValue('^/(app(_[\\w]+)?\\.php/)?_wdt')->end() | |||
| ->scalarNode('excluded_ajax_paths')->defaultValue('index.php?_wdt')->end() | |||
There was a problem hiding this comment.
that's not the right update. It will now match index.php_wdt and index.ph_wdt (and anywhere in the URL, not only at the start), while it should be matching /_wdt and /index.php/_wdt
|
and we should actually change it in 3.4, supporting both |
|
hi @stof thanks for u're review, you want something like this ?
|
|
it matches try something like
|
|
@ro0NL thanks, i tried with |
5445c10 to
423abe9
Compare
ro0NL
reviewed
Feb 21, 2018
| @@ -38,7 +38,7 @@ public function getConfigTreeBuilder() | |||
| ->children() | |||
| ->booleanNode('toolbar')->defaultFalse()->end() | |||
| ->booleanNode('intercept_redirects')->defaultFalse()->end() | |||
| ->scalarNode('excluded_ajax_paths')->defaultValue('^/(app(_[\\w]+)?\\.php/)?_wdt')->end() | |||
| ->scalarNode('excluded_ajax_paths')->defaultValue('^/((?:index|app(_[\w]+)?)\.php/)?_wdt')->end() | |||
There was a problem hiding this comment.
perhaps to fully clarify the regex remove ?: as well.. (it's not really needed) since you removed escaped \ also (before \\, but also not really needed).
ro0NL
approved these changes
Feb 21, 2018
0ce89f6 to
15b44bd
Compare
dunglas
approved these changes
Feb 21, 2018
Simperfit
approved these changes
Feb 21, 2018
15b44bd to
869b81d
Compare
ro0NL
suggested changes
Feb 22, 2018
| @@ -38,7 +38,7 @@ public function getConfigTreeBuilder() | |||
| ->children() | |||
| ->booleanNode('toolbar')->defaultFalse()->end() | |||
| ->booleanNode('intercept_redirects')->defaultFalse()->end() | |||
| ->scalarNode('excluded_ajax_paths')->defaultValue('^/(app(_[\\w]+)?\\.php/)?_wdt')->end() | |||
| ->scalarNode('excluded_ajax_paths')->defaultValue('^/((index|app(_[\w]+)?).php/)?_wdt')->end() | |||
There was a problem hiding this comment.
The dot . still needs escaping ;) (\. that is)
ro0NL
approved these changes
Feb 24, 2018
|
For 3.4 i guess |
8000
fabpot
approved these changes
Feb 24, 2018
|
Thank you @jenaye. |
fabpot
added a commit
that referenced
this pull request
Feb 24, 2018
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #26177). Discussion ---------- Update excluded_ajax_paths for sf4 | Q | A | ------------- | --- | Branch? | 4.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25941 | License | MIT | Doc PR | https://github.com/symfony/symfony-docs/pull/9267/files This PR update `excluded_ajax_paths` from `vendor/symfony/web-profiler-bundle/DependencyInjection/Configuration.php` because there is no neither `app.php` nor `app_dev.php` in symfony 4 We also need update this [Documentation](https://symfony.com/doc/current/reference/configuration/web_profiler.html) Commits ------- ce01097 Update excluded_ajax_paths for sf4
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 27, 2018
This PR was merged into the master branch. Discussion ---------- Update Documentation excluded_ajax_paths sf4 Linked with this PR : symfony/symfony#26177 Commits ------- 31f75d3 update doc sf4 for excluded_ajax_paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update
excluded_ajax_pathsfromvendor/symfony/web-profiler-bundle/DependencyInjection/Configuration.phpbecausethere is no neither
app.phpnorapp_dev.phpin symfony 4We also need update this Documentation