8000 do not mock the container builder in tests by xabbuh · Pull Request #26165 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

do not mock the container builder in tests #26165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2018
Merged

do not mock the container builder in tests #26165

merged 1 commit into from
Feb 14, 2018

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Feb 13, 2018
Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Feb 13, 2018
@xabbuh xabbuh mentioned this pull request Feb 13, 2018
Merged
stof
stof reviewed Feb 13, 2018
View reviewed changes
...ymfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/CachePoolPrunerPassTest.php

$pass = new CachePoolPrunerPass();
$pass->process($container);

// the container is untouched (i.e. no new definitions or aliases)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still allows altering the existing definitions (well, except that you use an empty builder in this test)

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 777acfb into symfony:3.4 Feb 14, 2018
nicolas-grekas added a commit that referenced this pull request Feb 14, 2018
@nicolas-grekas
minor #26165 do not mock the container builder in tests (xabbuh)
6b51add 
This PR was merged into the 3.4 branch.

Discussion
----------

do not mock the container builder in tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

777acfb do not mock the container builder in tests
@xabbuh xabbuh deleted the container-mocks branch February 14, 2018 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @nicolas-grekas @stof @carsonbot
0