8000 do not mock the container builder in tests by xabbuh · Pull Request #26087 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

do not mock the container builder in tests #26087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2018
Merged

do not mock the container builder in tests #26087

merged 1 commit into from
Feb 11, 2018

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Feb 8, 2018
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 2.7 milestone Feb 8, 2018
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit dab4222 into symfony:2.7 Feb 11, 2018
nicolas-grekas added a commit that referenced this pull request Feb 11, 2018
@nicolas-grekas
minor #26087 do not mock the container builder in tests (xabbuh)
65bab99 
This PR was merged into the 2.7 branch.

Discussion
----------

do not mock the container builder in tests

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

dab4222 do not mock the container builder in tests
@nicolas-grekas
Copy link
Member

I'm sorry @xabbuh but I didn't manage to merge this fully into 3.4. I reverted some changes that conflicted there. Please send a new PR on 3.4...

@xabbuh xabbuh deleted the container-mocks branch February 11, 2018 18:58
@xabbuh
Copy link
Member Author
xabbuh commented Feb 13, 2018

see #26165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @nicolas-grekas @dunglas @chalasr @carsonbot
0