8000 [SecurityBundle] add missing logout_on_user_change options by xabbuh · Pull Request #25461 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[SecurityBundle] add missing logout_on_user_change options #25461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2017
Merged

[SecurityBundle] add missing logout_on_user_change options #25461

merged 1 commit into from
Dec 12, 2017

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Dec 12, 2017
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh
add missing logout_on_user_change options
< 8000 input type="hidden" name="dropdown_direction" value="w" autocomplete="off" data-targets="batch-deferred-content.inputs" />
fde1f48
@xabbuh xabbuh added this to the 3.4 milestone Dec 12, 2017
@xabbuh
Copy link
Member Author
xabbuh commented Dec 12, 2017

I am just a bit confused that this did not fail earlier.

chalasr
chalasr approved these changes Dec 12, 2017
View reviewed changes
Copy link
Member
@chalasr chalasr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too 🤔

@chalasr
Copy link
Member
chalasr commented Dec 12, 2017

Good catch, thanks @xabbuh.

@chalasr chalasr merged commit fde1f48 into symfony:3.4 Dec 12, 2017
chalasr added a commit that referenced this pull request Dec 12, 2017
@chalasr
minor #25461 [SecurityBundle] add missing logout_on_user_change optio…
24e274d 
…ns (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[SecurityBundle] add missing logout_on_user_change options

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

fde1f48 add missing logout_on_user_change options
@xabbuh xabbuh deleted the fix-tests branch December 12, 2017 11:44
@dunglas
Copy link
Member
dunglas commented Dec 15, 2017 •
edited
Loading

This is annoying when you want to support both <= 3.4 (where the option doesn't exist at all) and >=3.4 (where it's mandatory to set the option).

@chalasr
Copy link
Member
chalasr commented Dec 15, 2017

@dunglas I know :/ but it's the only way we found to fix an important flaw in 4.0 (see #23882)

@dunglas
Copy link
Member
dunglas commented Dec 15, 2017

Is it possible to enable this flag in PHP (to do it using feature detection)?

@dunglas
Copy link
Member
dunglas commented Dec 15, 2017 •
edited
Loading

Here is a workaround: api-platform/core#1566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug SecurityBundle Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @chalasr @dunglas @carsonbot
0