8000 Fix tests by dunglas · Pull Request #1566 · api-platform/core · GitHub
[go: up one dir, main page]
Skip to content

Fix tests #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 15, 2017
Merged

Fix tests #1566

merged 6 commits into from
Dec 15, 2017

Conversation

dunglas
Copy link
Member
@dunglas dunglas commented Dec 15, 2017
Q A
Bug fix? yes/no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR an/a

@dunglas dunglas mentioned this pull request Dec 15, 2017
Merged
chalasr
chalasr reviewed Dec 15, 2017
View reviewed changes
tests/Fixtures/app/AppKernel.php Outdated
],
];

if (method_exists(ContextListener, 'setLogoutOnUserChange')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ::class

chalasr
chalasr reviewed Dec 15, 2017
View reviewed changes
tests/Fixtures/app/AppKernel.php Outdated
'provider' => 'chain_provider',
'http_basic' => null,
'anonymous' => null,
'logout_on_user_change' => true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed :)

@dunglas dunglas merged commit 1e0104c into api-platform:2.1 Dec 15, 2017
@dunglas dunglas deleted the fix_tests branch December 15, 2017 20:37
hoangnd25 pushed a commit to hoangnd25/core that referenced this pull request Feb 23, 2018
@dunglas
Fix tests (api-platform#1566)
48dfb4f
@meyerbaptiste meyerbaptiste mentioned this pull request Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dunglas @chalasr
0