8000 [DI] Fix non-string class handling in PhpDumper by nicolas-grekas · Pull Request #25354 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[DI] Fix non-string class handling in PhpDumper #25354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25353
License MIT
Doc PR -

@sroze
Copy link
Contributor
sroze commented Dec 6, 2017

Shouldn't we try to stringify instead?

@nicolas-grekas
Copy link
Member Author

The outcome here is a few less classes/files inlined. Not a big deal. Resolving the parameter could led to subtle bugs that are not worth the effort.

@fabpot
Copy link
Member
fabpot commented Dec 8, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 28f0086 into symfony:3.4 Dec 8, 2017
fabpot added a commit that referenced this pull request Dec 8, 2017
…rekas, sroze)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Fix non-string class handling in PhpDumper

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25353
| License       | MIT
| Doc PR        | -

Commits
-------

28f0086 Ensure that inlined services with parameterized class name can be dumped
730b156 [DI] Fix non-string class handling in PhpDumper
@nicolas-grekas nicolas-grekas deleted the di-fix branch December 8, 2017 12:45
This was referenced Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0