[DI] Fix non-string class handling in PhpDumper #25354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25353 |
| License | MIT |
| Doc PR | - |
|
Shouldn't we try to stringify instead? |
|
The outcome here is a few less classes/files inlined. Not a big deal. Resolving the parameter could led to subtle bugs that are not worth the effort. |
fabpot
approved these changes
Dec 8, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 8, 2017
…rekas, sroze) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Fix non-string class handling in PhpDumper | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25353 | License | MIT | Doc PR | - Commits ------- 28f0086 Ensure that inlined services with parameterized class name can be dumped 730b156 [DI] Fix non-string class handling in PhpDumper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.