-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[3.4] container.dumper.inline_class_loader triggers access level exception #25353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
With the parameter enabled, some classes on the hot path are now always loaded. Previously, this class would have been loaded lazily, and thus the error would been seen when actually using the service. |
Ok, that sounds logic. I hot fixed it in vendor to temporary bypass it and the next error pops up, also probably from a wrong implementation but it's totally different so wanted to share it with you:
|
Did you clear your cache after "fixing within the vendors" ? 🤔 |
You folks are doing too crazy things :) |
Hahaha :) Never knew this vendor bundle was doing that.. :( @sroze Yes I did, same error. @nicolas-grekas Change works :-) Thanks! |
…rekas, sroze) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Fix non-string class handling in PhpDumper | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25353 | License | MIT | Doc PR | - Commits ------- 28f0086 Ensure that inlined services with parameterized class name can be dumped 730b156 [DI] Fix non-string class handling in PhpDumper
I just upgraded from 3.3.13 to 3.4.1, which goes correctly now (had some issues, solved now). I read somewhere that enabling the
container.dumper.inline_class_loader
could dramatically speed up development environments, which I can confirm. Load times for the first page tested on development was 50% faster.The first request works after clearing cache, but my second request (doesn't matter which page in my system) runs into the following error. Without the parameter enabled, this error does not occur.
$options
in PhpcrDriver isprivate
. In ElFinderVolumeDriver it is indeedprotected
. I understand that this is an issue anyway.But I'm not sure why it only errors out when this parameter is enabled and not before..
The text was updated successfully, but these errors were encountered: