8000 [Form] Add phpdoc to `RequestHandlerInterface::isFileUpload()` method by issei-m · Pull Request #25040 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Add phpdoc to RequestHandlerInterface::isFileUpload() method #25040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Form] Add phpdoc to RequestHandlerInterface::isFileUpload() method #25040

wants to merge 2 commits into from

Conversation

issei-m
Copy link
Contributor
@issei-m issei-m commented Nov 20, 2017
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? Not confirmed, but the changes are completely minor
Fixed tickets -
License MIT
Doc PR -

fabpot
fabpot requested changes Nov 20, 2017
View reviewed changes
src/Symfony/Component/Form/RequestHandlerInterface.php Outdated
@@ -27,7 +27,9 @@
public function handleRequest(FormInterface $form, $request = null);

/**
* @param mixed $data
* Returns true if the given data is used to upload the file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns true if the given data is a file upload?

nicolas-grekas
nicolas-grekas reviewed Nov 20, 2017
View reviewed changes
src/Symfony/Component/Form/RequestHandlerInterface.php Outdated
* @param mixed $data
* Returns true if the given data is used to upload the file.
*
* @param mixed $data the form field data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uppercase "T" [The...]

@issei-m
Copy link
Contributor Author
issei-m commented Nov 20, 2017

@fabpot @nicolas-grekas Thank you guys for your advice! and now I've fixed it :)

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Nov 20, 2017
@nicolas-grekas
Copy link
Member

Thank you @issei-m.

nicolas-grekas added a commit that referenced this pull request Nov 20, 2017
@nicolas-grekas
minor #25040 [Form] Add phpdoc to `RequestHandlerInterface::isFileUpl…
f1b7921 
…oad()` method (issei-m)

This PR was squashed before being merged into the 2.7 branch (closes #25040).

Discussion
----------

[Form] Add phpdoc to `RequestHandlerInterface::isFileUpload()` method

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | Not confirmed, but the changes are completely minor
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the master branch.
- Please fill in this template according to the PR you're about to submit.
- Replace this comment by a description of what your PR is solving.
-->

Commits
-------

faf5470 [Form] Add phpdoc to `RequestHandlerInterface::isFileUpload()` method
@issei-m issei-m deleted the add-doc branch November 21, 2017 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot requested changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@issei-m @nicolas-grekas @fabpot @carsonbot
0