[Console] Fix global console flag when used in chain #24987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52a6cc2 to
6938a0a
Compare
|
For 2.7? |
|
Yes I will rebase it :)
Le jeu. 16 nov. 2017 à 16:18, Robin Chalas <notifications@github.com> a
écrit :
… For 2.7?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24987 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADSq8mGwVKCDC_Tw8D0aRjwEFe0DKJ5Rks5s3EQ2gaJpZM4QgEfq>
.
|
6938a0a to
363cbaf
Compare
ro0NL
approved these changes
Nov 17, 2017
| @@ -168,12 +168,12 @@ private function parseArgument($token) | |||
| $arg = $this->definition->getArgument($c); | |||
| $this->arguments[$arg->getName()] = $arg->isArray() ? array($token) : $token; | |||
|
|
|||
| // if last argument isArray(), append token to last argument | |||
| // if last argument isArray(), append token to last argument | |||
| @@ -282,6 +282,14 @@ public function hasParameterOption($values) | |||
| if ($token === $value || 0 === strpos($token, $value.'=')) { | |||
| return true; | |||
| } | |||
|
|
|||
| if (0 === strpos($token, '-') && 0 !== strpos($token, '--')) { | |||
There was a problem hiding this comment.
i dont follow it really, but it works 👍
$ bin/console router:match -hq
before: exception (missing argument)
after: quiet :)
fabpot
reviewed
Nov 18, 2017
| } elseif ($this->definition->hasArgument($c - 1) && $this->definition->getArgument($c - 1)->isArray()) { | ||
| $arg = $this->definition->getArgument($c - 1); | ||
| $this->arguments[$arg->getName()][] = $token; | ||
|
|
||
| // unexpected argument | ||
| // unexpected argument |
ffb69d5 to
70f1d96
Compare
70f1d96 to
1f8db73
Compare
chalasr
approved these changes
Nov 23, 2017
ogizanagi
approved these changes
Nov 24, 2017
|
Thanks for fixing this bug Hamza. |
chalasr
pushed a commit
that referenced
this pull request
Nov 26, 2017
…erfit) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Fix global console flag when used in chain | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #23876 | License | MIT | Doc PR | Because SymfonyCon is great we can create pull request in it ! (this was preparer in the plane and I can push it just right now ;)) Finished in the #SymfonyConHackday2017 Commits ------- 1f8db73 [Console] Fix global console flag when used in chain
This was referenced Nov 30, 2017
Merged
Merged
Merged
|
@fabpot This results in a bug in v2.8.32. When I try to run a command the command is not actually executed but the Symfony shell is opened (same result as with adding the --shell option). |
|
I will try to reproduce then fix this behaviour. Could you try to provide a
reproducer ?
Le mer. 13 déc. 2017 à 15:40, John Zwarthoed <notifications@github.com> a
écrit :
… @fabpot <https://github.com/fabpot> This results in a bug in v2.8.32.
When I try to run a command the command is not actually executed but the
Symfony shell is opened (same result as with adding the --shell option).
Did not check other releases though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24987 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADSq8mpnV9LEOa67zaURyoqxMDk9XbE0ks5s_-HtgaJpZM4QgEfq>
.
|
8000
|
Just running app/console already causes the issue for me (with symfony/console 2.8.32) |
|
I've just tested with symfony/console 2.8.32 and I can't reproduce the problem : |
|
Welcome to the Symfony shell (2.8.32 - app/dev/debug). At the prompt, type help for some help, To exit the shell, type ^D. Symfony > Thats what i mean. You’re not supposed to be stuck in de symfony shell after running a command if i’m not mistaken. |
|
Oh wait, thats with —shell. I’ll check when i’m home |
8000
|
Apparently it only occurs when running with 'test' in the environment. |
|
I am able to reproduce it on a fresh project: Not able to reproduce in 3.4 |
|
Ok I understand it, I submit a PR to fix the bug |
fabpot
added a commit
that referenced
this pull request
Dec 14, 2017
… alias (Simperfit) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Fix a bug when passing a letter that could be an alias | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | see #24987 (comment) | License | MIT | Doc PR | Fixing the global in console commands I've introduced a bug where when you pass -e=test it finds it a --shell, this fix the wrong behaviour. cc @Zwartpet Commits ------- a8871de [Console] Fix a bug when passing a letter that could be an alias
This was referenced Jan 18, 2018
greg-1-anderson
added a commit
to greg-1-anderson/symfony
that referenced
this pull request
Jan 20, 2018
|
breaks in #25825 apparently |
greg-1-anderson
added a commit
to greg-1-anderson/symfony
that referenced
this pull request
Jan 22, 2018
…arameterOption.
|
reverted |
fabpot
added a commit
that referenced
this pull request
Jan 29, 2018
* 2.7: [HttpFoundation] Use the correct syntax for session gc based on Pdo driver Revert "bug #24987 [Console] Fix global console flag when used in chain (Simperfit)" Revert "bug #25487 [Console] Fix a bug when passing a letter that could be an alias (Simperfit)" Disable CSP header on exception pages only in debug Fixed submitting disabled buttons Fixed Button::setParent() when already submitted Improve assertions SCA: get rid of repetitive calls allow null values for root nodes in YAML configs [VarDumper] Fix docblock Improve phpdoc to make it more explicit
fabpot
added a commit
that referenced
this pull request
Jan 29, 2018
* 2.8: [HttpFoundation] Use the correct syntax for session gc based on Pdo driver Removed assertDateTimeEquals() methods. Revert "bug #24987 [Console] Fix global console flag when used in chain (Simperfit)" Revert "bug #25487 [Console] Fix a bug when passing a letter that could be an alias (Simperfit)" Disable CSP header on exception pages only in debug Fixed submitting disabled buttons Fixed Button::setParent() when already submitted Improve assertions Improve assertions SCA: get rid of repetitive calls allow null values for root nodes in YAML configs [VarDumper] Fix docblock Improve phpdoc to make it more explicit
fabpot
added a commit
that referenced
this pull request
Jan 29, 2018
* 3.3: [HttpFoundation] Use the correct syntax for session gc based on Pdo driver Removed assertDateTimeEquals() methods. Revert "bug #24987 [Console] Fix global console flag when used in chain (Simperfit)" Revert "bug #25487 [Console] Fix a bug when passing a letter that could be an alias (Simperfit)" Disable CSP header on exception pages only in debug Fixed submitting disabled buttons Fixed Button::setParent() when already submitted Improve assertions Restore RoleInterface import Improve assertions SCA: get rid of repetitive calls allow null values for root nodes in YAML configs revert useless tests fixtures changes [VarDumper] Fix docblock Improve phpdoc to make it more explicit
fabpot
added a commit
that referenced
this pull request
Jan 29, 2018
* 3.4: [HttpFoundation] Use the correct syntax for session gc based on Pdo driver Removed assertDateTimeEquals() methods. Revert "bug #24987 [Console] Fix global console flag when used in chain (Simperfit)" Revert "bug #25487 [Console] Fix a bug when passing a letter that could be an alias (Simperfit)" Disable CSP header on exception pages only in debug Fixed submitting disabled buttons Fixed Button::setParent() when already submitted Improve assertions Restore RoleInterface import [Console] Provide a bugfix where an array could be passed Improve assertions SCA: get rid of repetitive calls allow null values for root nodes in YAML configs revert useless tests fixtures changes [VarDumper] Fix docblock Improve phpdoc to make it more explicit [DI] Fix initialization of legacy containers by delaying include_once
fabpot
added a commit
that referenced
this pull request
Jan 29, 2018
* 4.0: [HttpFoundation] Use the correct syntax for session gc based on Pdo driver Removed assertDateTimeEquals() methods. Revert "bug #24987 [Console] Fix global console flag when used in chain (Simperfit)" Revert "bug #25487 [Console] Fix a bug when passing a letter that could be an alias (Simperfit)" Disable CSP header on exception pages only in debug Fixed submitting disabled buttons Fixed Button::setParent() when already submitted Improve assertions Restore RoleInterface import [Console] Provide a bugfix where an array could be passed Improve assertions SCA: get rid of repetitive calls allow null values for root nodes in YAML configs revert useless tests fixtures changes [VarDumper] Fix docblock Improve phpdoc to make it more explicit [DI] Fix initialization of legacy containers by delaying include_once
fabpot
added a commit
that referenced
this pull request
Feb 7, 2018
… used with multiple flags (greg-1-anderson) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Fix hasParameterOption / getParameterOption when used with multiple flags | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no (Fixes BC break in #24987) | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25825 | License | MIT | Doc PR | n/a Proposed resolution to #25825: - Back out #24987 - Fix getParameterOption for short options with values, e.g. `-edev` Commits ------- 35f98e2 Follow-on to #25825: Fix edge case in getParameterOption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because SymfonyCon is great we can create pull request in it ! (this was preparer in the plane and I can push it just right now ;))
Finished in the #SymfonyConHackday2017