WIP #25825: Add a failing test to demonstrate bug introduced in #24987. #25852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ebc8a4 to
01ed485
Compare
|
@greg-1-anderson the fix should be submitted against branch 2.7, isn't it? Would you like to submit one? |
|
@nicolas-grekas The bug was committed to many versions of Symfony. If 2.7 is where I should start, I'll be happy to make a PR there to fix this. |
|
Yes, that's how we manage this: we first merge in the lowest branch, then we merge that branch up to master. |
|
Work continues in #25893 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some failing tests to demonstrate the problem introduced by the above-referenced PR.
The main issue introduced is demonstrated by test
[B].hasParameterOption('-s')returns the wrong result because it confuses the characters in the value of the-eflag for additional options.Proposed resolution:
Back out #24987
Impact:
Symfony Console will once again have the limitation that one cannot use
cli.php -fhto set the-fflag AND get help via the-hflag, becausehasParameterOption/getParameterOptiononly work with short parameters that appear by themselves (e.g.cli.php -f -h). This limitation is necessary becausehasParameterOption()has no access to the input definition.In the tests below, backing out #24987 would have the following effect:
[A]: Control test:getOptions()/getOption()will continue to work as always.[B]: Fixed[C]and[D]: Will fail. Fixed by [Console] Fix global console flag when used in chain #24987, but introduces a worse problem[E],[F]and[G]: Not supported.Remaining work:
The function
getParameterOptionstill does not work correctly for short options with values. This bug was pre-existing, prior to #24987, and was not affected by that PR. See the comment on failing test[I].