8000 Ensure that PHPUnit's error handler is still working in isolated tests by alexpott · Pull Request #24575 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Ensure that PHPUnit's error handler is still working in isolated tests #24575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Ensure that PHPUnit's error handler is still working in isolated tests #24575

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fb8ba79
Ensure that PHPUnit's error handler is still working in isolated tests
alexpott Oct 16, 2017
d985e80
Coding standards
alexpott Oct 16, 2017
d56b8b9
Fix some of the tests
alexpott Oct 16, 2017
cdcacce
Fix autoloading of bootstrap.php in tests under isolation
alexpott Oct 16, 2017
a1e028f
Remove unused use
alexpott Oct 16, 2017
810b131
Some clean ups
alexpott Oct 16, 2017
07ca35a
Remove unnecessary changes
alexpott Oct 18, 2017
1fb801a
Add missing word.
alexpott Oct 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Coding standards
  • Loading branch information
@alexpott
alexpott committed Oct 24, 2017
commit d985e800ab9d1aa49866c03a9d31d62e68738812
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ public static function collectDeprecations($outputFile)
// This can registered before the PHPUnit error handler.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: missing "be" (... can be...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest push - I did a rebase to get the latest changes so had to force push.

if (!$previousErrorHandler) {
$UtilPrefix = class_exists('PHPUnit_Util_ErrorHandler') ? 'PHPUnit_Util_' : 'PHPUnit\Util\\';
$previousErrorHandler = $UtilPrefix . 'ErrorHandler::handleError';
$previousErrorHandler = $UtilPrefix.'ErrorHandler::handleError';
}

register_shutdown_function(function () use ($outputFile, &$deprecations) {
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Bridge/PhpUnit/Tests/ProcessIsolationTest.php
View file Edit file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ protected function setUp()
DeprecationErrorHandler::collectDeprecations(getenv('SYMFONY_DEPRECATIONS_SERIALIZE'));
parent::setUp();
}

/**
* @expectedDeprecation Test abc
*/
Expand Down
0