8000 Ensure that PHPUnit's error handler is still working in isolated tests by alexpott · Pull Request #24575 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Ensure that PHPUnit's error handler is still working in isolated tests #24575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Some clean ups
  • Loading branch information
alexpott committed Oct 24, 2017
commit 810b131506d1192c624f88d24de046139399cffd
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@ public function endTest($test, $time)
}
}
$this->runsInSeparateProcess = false;
putenv('SYMFONY_DEPRECATIONS_SERIALIZE=');
}

if ($this->expectedDeprecations) {
Expand Down Expand Up @@ -317,7 +318,6 @@ public function endTest($test, $time)
$result->addWarning($test, new $Warning('Using the "Legacy" prefix to mark all tests of a class as legacy is deprecated since version 3.3 and will be removed in 4.0. Use the "@group legacy" notation instead to add the test to the legacy group.'), $time);
}
}
putenv('SYMFONY_DEPRECATIONS_SERIALIZE=');
}

public function handleError($type, $msg, $file, $line, $context = array())
Expand Down
1 change: 0 additions & 1 deletion src/Symfony/Bridge/PhpUnit/Tests/ProcessIsolationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
*/
class ProcessIsolationTest extends TestCase
{

/**
* @expectedDeprecation Test abc
*/
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Bridge/PhpUnit/bootstrap.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
// Detect if we're loaded by an actual run of phpunit
if ($ser = getenv('SYMFONY_DEPRECATIONS_SERIALIZE')) {
DeprecationErrorHandler::collectDeprecations($ser);

return;
}

Expand Down
0