[HttpKernel] "controller.service_arguments" services should be public #24126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Sep 7, 2017
fabpot
approved these changes
Sep 7, 2017
stof
approved these changes
Sep 7, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 7, 2017
…d be public (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [HttpKernel] "controller.service_arguments" services should be public | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Controller-as-services need to be public if they have constructor arguments (they don't need to if they have no arguments but that's for arcane reasons.) Since services tagged "controller.service_arguments" *are* controllers, they need to be public to enhance DX and remove some WTFs that some ppl reported to me. Commits ------- b9c6928 [HttpKernel] "controller.service_arguments" services should be public
Merged
javiereguiluz
added a commit
to symfony/demo
that referenced
this pull request
Sep 19, 2017
This PR was squashed before being merged into the master branch (closes #648). Discussion ---------- Update to Symfony 3.3.9 and fix latest changes The [second commit][1] remove the unnecessary configuration for controllers services fixed in symfony/symfony#24126 The third commit update Symfony Flex deps and update `phpunit.xml.dist` env vars according to symfony/recipes#170 and symfony/flex#148 <details> <summary>See "composer update" log trace.</summary> ```bash Installing dependencies (including require-dev) from lock file Package operations: 1 install, 45 updates, 0 removals - Updating composer/ca-bundle (1.0.7 => 1.0.8): Downloading (100%) - Updating symfony/doctrine-bridge (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/stopwatch (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/routing (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/http-foundation (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/event-dispatcher (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/debug (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/http-kernel (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/flex (v1.0.17 => v1.0.19): Downloading (100%) - Updating symfony/finder (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/filesystem (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/dependency-injection (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/config (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/class-loader (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/cache (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/framework-bundle (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/console (v3.3.8 => v3.3.9): Downloading (100%) - Updating doctrine/doctrine-fixtures-bundle (2.3.0 => v2.4.0): Downloading (100%) - Updating symfony/asset (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/dom-crawler (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/browser-kit (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/css-selector (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/expression-language (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/inflector (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/property-access (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/options-resolver (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/intl (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/form (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/monolog-bridge (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/security (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/security-bundle (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/swiftmailer-bundle (v3.0.3 => v3.0.4): Downloading (100%) - Updating symfony/twig-bridge (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/twig-bundle (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/translation (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/validator (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/yaml (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/process (v3.3.8 => v3.3.9): Loading from cache - Installing composer/semver (1.4.2): Downloading (100%) - Updating friendsofphp/php-cs-fixer (v2.5.0 => v2.6.0): Downloading (100%) - Updating symfony/var-dumper (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/debug-bundle (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/dotenv (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/phpunit-bridge (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/web-profiler-bundle (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/web-server-bundle (v3.3.8 => v3.3.9): Loading from cache Generating autoload files ``` </details> [1]: ba751c7 Commits ------- 0f15099 Update to Symfony 3.3.9 and fix latest changes
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 22, 2017
This PR was merged into the 3.3 branch. Discussion ---------- Update 3.3-di-changes.rst Now controllers tagged with `controller.service_arguments` are public `true` by definition symfony/symfony#24126 Commits ------- 33b0ab8 Update 3.3-di-changes.rst
sayjun0505
added a commit
to sayjun0505/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was squashed before being merged into the master branch (closes #648). Discussion ---------- Update to Symfony 3.3.9 and fix latest changes The [second commit][1] remove the unnecessary configuration for controllers services fixed in symfony/symfony#24126 The third commit update Symfony Flex deps and update `phpunit.xml.dist` env vars according to symfony/recipes#170 and symfony/flex#148 <details> <summary>See "composer update" log trace.</summary> ```bash Installing dependencies (including require-dev) from lock file Package operations: 1 install, 45 updates, 0 removals - Updating composer/ca-bundle (1.0.7 => 1.0.8): Downloading (100%) - Updating symfony/doctrine-bridge (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/stopwatch (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/routing (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/http-foundation (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/event-dispatcher (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/debug (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/http-kernel (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/flex (v1.0.17 => v1.0.19): Downloading (100%) - Updating symfony/finder (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/filesystem (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/dependency-injection (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/config (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/class-loader (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/cache (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/framework-bundle (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/console (v3.3.8 => v3.3.9): Downloading (100%) - Updating doctrine/doctrine-fixtures-bundle (2.3.0 => v2.4.0): Downloading (100%) - Updating symfony/asset (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/dom-crawler (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/browser-kit (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/css-selector (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/expression-language (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/inflector (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/property-access (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/options-resolver (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/intl (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/form (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/monolog-bridge (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/security (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/security-bundle (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/swiftmailer-bundle (v3.0.3 => v3.0.4): Downloading (100%) - Updating symfony/twig-bridge (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/twig-bundle (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/translation (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/validator (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/yaml (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/process (v3.3.8 => v3.3.9): Loading from cache - Installing composer/semver (1.4.2): Downloading (100%) - Updating friendsofphp/php-cs-fixer (v2.5.0 => v2.6.0): Downloading (100%) - Updating symfony/var-dumper (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/debug-bundle (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/dotenv (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/phpunit-bridge (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/web-profiler-bundle (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/web-server-bundle (v3.3.8 => v3.3.9): Loading from cache Generating autoload files ``` </details> [1]: symfony/demo@ba751c7 Commits ------- 0f15099 Update to Symfony 3.3.9 and fix latest changes
spider-yamet
added a commit
to spider-yamet/sym_proj
that referenced
this pull request
Apr 16, 2023
8000
This PR was squashed before being merged into the master branch (closes #648). Discussion ---------- Update to Symfony 3.3.9 and fix latest changes The [second commit][1] remove the unnecessary configuration for controllers services fixed in symfony/symfony#24126 The third commit update Symfony Flex deps and update `phpunit.xml.dist` env vars according to symfony/recipes#170 and symfony/flex#148 <details> <summary>See "composer update" log trace.</summary> ```bash Installing dependencies (including require-dev) from lock file Package operations: 1 install, 45 updates, 0 removals - Updating composer/ca-bundle (1.0.7 => 1.0.8): Downloading (100%) - Updating symfony/doctrine-bridge (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/stopwatch (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/routing (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/http-foundation (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/event-dispatcher (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/debug (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/http-kernel (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/flex (v1.0.17 => v1.0.19): Downloading (100%) - Updating symfony/finder (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/filesystem (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/dependency-injection (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/config (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/class-loader (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/cache (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/framework-bundle (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/console (v3.3.8 => v3.3.9): Downloading (100%) - Updating doctrine/doctrine-fixtures-bundle (2.3.0 => v2.4.0): Downloading (100%) - Updating symfony/asset (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/dom-crawler (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/browser-kit (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/css-selector (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/expression-language (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/inflector (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/property-access (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/options-resolver (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/intl (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/form (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/monolog-bridge (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/security (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/security-bundle (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/swiftmailer-bundle (v3.0.3 => v3.0.4): Downloading (100%) - Updating symfony/twig-bridge (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/twig-bundle (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/translation (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/validator (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/yaml (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/process (v3.3.8 => v3.3.9): Loading from cache - Installing composer/semver (1.4.2): Downloading (100%) - Updating friendsofphp/php-cs-fixer (v2.5.0 => v2.6.0): Downloading (100%) - Updating symfony/var-dumper (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/debug-bundle (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/dotenv (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/phpunit-bridge (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/web-profiler-bundle (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/web-server-bundle (v3.3.8 => v3.3.9): Loading from cache Generating autoload files ``` </details> [1]: symfony/demo@ba751c7 Commits ------- 0f15099 Update to Symfony 3.3.9 and fix latest changes
frederickboyd
added a commit
to frederickboyd/frederickboyd
that referenced
this pull request
May 25, 2025
This PR was squashed before being merged into the master branch (closes #648). Discussion ---------- Update to Symfony 3.3.9 and fix latest changes The [second commit][1] remove the unnecessary configuration for controllers services fixed in symfony/symfony#24126 The third commit update Symfony Flex deps and update `phpunit.xml.dist` env vars according to symfony/recipes#170 and symfony/flex#148 <details> <summary>See "composer update" log trace.</summary> ```bash Installing dependencies (including require-dev) from lock file Package operations: 1 install, 45 updates, 0 removals - Updating composer/ca-bundle (1.0.7 => 1.0.8): Downloading (100%) - Updating symfony/doctrine-bridge (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/stopwatch (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/routing (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/http-foundation (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/event-dispatcher (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/debug (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/http-kernel (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/flex (v1.0.17 => v1.0.19): Downloading (100%) - Updating symfony/finder (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/filesystem (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/dependency-injection (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/config (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/class-loader (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/cache (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/framework-bundle (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/console (v3.3.8 => v3.3.9): Downloading (100%) - Updating doctrine/doctrine-fixtures-bundle (2.3.0 => v2.4.0): Downloading (100%) - Updating symfony/asset (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/dom-crawler (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/browser-kit (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/css-selector (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/expression-language (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/inflector (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/property-access (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/options-resolver (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/intl (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/form (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/monolog-bridge (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/security (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/security-bundle (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/swiftmailer-bundle (v3.0.3 => v3.0.4): Downloading (100%) - Updating symfony/twig-bridge (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/twig-bundle (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/translation (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/validator (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/yaml (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/process (v3.3.8 => v3.3.9): Loading from cache - Installing composer/semver (1.4.2): Downloading (100%) - Updating friendsofphp/php-cs-fixer (v2.5.0 => v2.6.0): Downloading (100%) - Updating symfony/var-dumper (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/debug-bundle (v3.3.8 => v3.3.9): Loading from cache - Updating symfony/dotenv (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/phpunit-bridge (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/web-profiler-bundle (v3.3.8 => v3.3.9): Downloading (100%) - Updating symfony/web-server-bundle (v3.3.8 => v3.3.9): Loading from cache Generating autoload files ``` </details> [1]: symfony/demo@ba751c7 Commits ------- 0f15099 Update to Symfony 3.3.9 and fix latest changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controller-as-services need to be public if they have constructor arguments (they don't need to if they have no arguments but that's for arcane reasons.)
Since services tagged "controller.service_arguments" are controllers, they need to be public to enhance DX and remove some WTFs that some ppl reported to me.