8000 Add default env vars for PHPUnit by fabpot · Pull Request #170 · symfony/recipes · GitHub
[go: up one dir, main page]
Skip to content

Add default env vars for PHPUnit #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2017
Merged

Add default env vars for PHPUnit #170

merged 1 commit into from
Sep 12, 2017

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Sep 6, 2017
Q A
License MIT

symfony-bot
symfony-bot previously approved these changes Sep 6, 2017
View reviewed changes
@fabpot fabpot mentioned this pull request Sep 6, 2017
Closed
nicolas-grekas
nicolas-grekas previously approved these changes Sep 6, 2017
View reviewed changes
@fabpot
Copy link
Member Author
fabpot commented Sep 6, 2017

Maybe these could be managed by Flex like done for the .env.dist file. Let me see that before merging.

xabbuh
xabbuh reviewed Sep 6, 2017
View reviewed changes
phpunit/phpunit/4.7/phpunit.xml.dist
@@ -9,7 +9,11 @@
>
<php>
<ini name="error_reporting" value="-1" />
<server name="KERNEL_CLASS" value="App\Kernel" />
<env name="KERNEL_CLASS" value="App\Kernel" />
10000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why using env here when we just started checking $_SERVER (see e.g. #156)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it's the correct concept, and maps to the .env file
_SERVER mixes several sources, so it's confusing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the difference if I don't miss anything is that PHPUnit unline the Dotenv component does not populate the $_SERVER array with this config.

For example, take this config:

    <php>
        <server name="foo" value="bar" />
        <env name="foobar" value="baz" />
    </php>

It ends up with this output:

(
    [DOCUMENT_ROOT] => 
    [PATH_TRANSLATED] => ./phpunit
    [PHP_SELF] => ./phpunit
    [PWD] => /Users/christian/symfony
    [REQUEST_TIME] => 1504717866
    [REQUEST_TIME_FLOAT] => 1504717866.6028
    [SCRIPT_FILENAME] => ./phpunit
    [SCRIPT_NAME] => ./phpunit
    [TMPDIR] => /var/folders/9_/wkjkz_ms2hn7rkr4vm4b68t00000gn/T/
    [USER] => christian
    [_] => ./phpunit
    [argc] => 3
    [argv] => Array
        (
            [0] => ./phpunit
            [1] => --colors=always
            [2] => src/Symfony/Component/Filesystem/
        )

    [foo] => bar
)
Array
(
    [foobar] => baz
)

Produced by:

ksort($_SERVER);
print_r($_SERVER);
ksort($_ENV);
print_r($_ENV);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's stupid :)
Anyway, since getenv('foo') returns only from <env>, I think we have no choice but use it.

Copy link
Member
@yceruto yceruto Sep 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this conf wouldn't meet its goal because: https://github.com/symfony/symfony/blob/d102fc08e48451aee932a8138d9cfaa726cee288/src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.php#L117.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yceruto good catch, can you send a PR to fix this? it should work!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what I should fix here? you mean check both vars $_SERVER and $_ENV in KernelTestCase?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's what I mean

@yceruto
Copy link
Member
yceruto commented Sep 6, 2017 •
edited
Loading

Will be great that Flex comes into play here to update the phpunit.xml.dist file too. Even, could we configure the default env vars in recipes for phpunit.xml.dist? It would allow to doctrine-bundle manifest to do something like this:

{
    ...
    "env": {
        "DATABASE_URL": "\"mysql://root@127.0.0.1:3306/symfony?charset=utf8mb4&serverVersion=5.7\""
    },
    "env_phpunit": {
        "DATABASE_URL": "\"sqlite:///%kernel.project_dir%/var/test.db\""
    }
}

Then, the current changes could be moved to framework-bundle manifest. Useful also for bundles intended for testing only.

@fabpot
Copy link
Member Author
fabpot commented Sep 11, 2017 •
edited
Loading

Closing in favor of symfony/flex#148

@fabpot fabpot closed this Sep 11, 2017
@fabpot fabpot reopened this Sep 11, 2017
symfony-bot
symfony-bot previously approved these changes Sep 11, 2017
View reviewed changes
@fabpot
Copy link
Member Author
fabpot commented Sep 11, 2017

Managing env vars in Flex is great, but as PHPUnit is always installed after the main packages, these env vars will never be there, so this PR is relevant after all.

@fabpot fabpot dismissed stale reviews from symfony-bot and nicolas-grekas via 2ca8e91 September 11, 2017 22:53
symfony-bot
symfony-bot previously approved these changes Sep 11, 2017
View reviewed changes
@fabpot
Copy link
Member Author
fabpot commented Sep 11, 2017

RFR

@yceruto
Copy link
Member
yceruto commented Sep 12, 2017 •
edited
Loading

but as PHPUnit is always installed after the main packages, these env vars will never be there...

The same would happen if phpunit is installed after any package with env vars, right? So for the sake of not losing the previous env vars, could Flex review the current packages/recipes installed and reconfigure this part just after install phpunit? If possible, the order in which it was installed wouldn't matter.

yceruto
yceruto reviewed Sep 12, 2017
View reviewed changes
phpunit/phpunit/4.7/phpunit.xml.dist Outdated
@@ -10,6 +10,10 @@
<php>
<ini name="error_reporting" value="-1" />
<server name="KERNEL_CLASS" value="App\Kernel" />
<server name="APP_ENV" value="test" />
<server name="APP_DEBUG" value="0" />
Copy link
Member
@yceruto yceruto Sep 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both APP_ENV and APP_DEBUG vars have no effect on kernel initialization, so new feature or bugfix? ... or simply we can remove them?

Also note that the current default value for debug mode is true in test env, here we are changing this to false.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed false to true for APP_DEBUG

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yceruto I think we need to add support for these env vars. Can you submit a PR for Symfony 3.4 to use env vars when options are not defined explicitly, and keep the fallback as is if the env vars are not define?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'm on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See symfony/symfony#24177

symfony-bot
symfony-bot previously approved these changes Sep 12, 2017
View reviewed changes
symfony-bot
symfony-bot previously approved these changes Sep 12, 2017
View reviewed changes
nicolas-grekas
nicolas-grekas previously approved these changes Sep 12, 2017
View reviewed changes
yceruto
yceruto reviewed Sep 12, 2017
View reviewed changes
phpunit/phpunit/4.7/phpunit.xml.dist Outdated
<server name="KERNEL_CLASS" value="App\Kernel" />
<env name="KERNEL_CLASS" value="App\Kernel" />
<env name="APP_ENV" value="test" />
<env name="APP_DEBUG" value="0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here <env name="APP_DEBUG" value="1" />

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@fabpot fabpot dismissed stale reviews from nicolas-grekas and symfony-bot via a6c656f September 12, 2017 18:48
fabpot
fabpot commented Sep 12, 2017
View reviewed changes
Copy link
Member Author
@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge now

@symfony-bot symfony-bot merged commit c2e9f8c into master Sep 12, 2017
This was referenced Sep 12, 2017
Merged
Merged
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Sep 13, 2017
@nicolas-grekas
bug #24177 [FrameworkBundle] Add support to environment variables APP…
3f4c47c 
…_ENV/DEBUG in KernelTestCase (yceruto)

This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle] Add support to environment variables APP_ENV/DEBUG in KernelTestCase

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony/recipes#170 (comment)
| License       | MIT
| Doc PR        | -

/cc @fabpot

Commits
-------

8d56744 Add support to environment variables APP_ENV/DEBUG in KernelTestCase
@yceruto yceruto mentioned this pull request Sep 13, 2017
Closed
@fabpot fabpot deleted the phpunit-tweak branch September 15, 2017 18:22
javiereguiluz added a commit to symfony/demo that referenced this pull request Sep 19, 2017
@javiereguiluz
feature #648 Update to Symfony 3.3.9 and fix latest changes (yceruto)
1af20c2 
This PR was squashed before being merged into the master branch (closes #648).

Discussion
----------

Update to Symfony 3.3.9 and fix latest changes

The [second commit][1] remove the unnecessary configuration for controllers services fixed in symfony/symfony#24126

The third commit update Symfony Flex deps and update `phpunit.xml.dist` env vars according to symfony/recipes#170 and symfony/flex#148

<details>
<summary>See "composer update" log trace.</summary>

```bash
Installing dependencies (including require-dev) from lock file
Package operations: 1 install, 45 updates, 0 removals
  - Updating composer/ca-bundle (1.0.7 => 1.0.8): Downloading (100%)
  - Updating symfony/doctrine-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/stopwatch (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/routing (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/http-foundation (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/event-dispatcher (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/http-kernel (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/flex (v1.0.17 => v1.0.19): Downloading (100%)
  - Updating symfony/finder (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/filesystem (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dependency-injection (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/config (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/class-loader (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/cache (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/framework-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/console (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating doctrine/doctrine-fixtures-bundle (2.3.0 => v2.4.0): Downloading (100%)
  - Updating symfony/asset (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dom-crawler (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/browser-kit (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/css-selector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/expression-language (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/inflector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/property-access (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/options-resolver (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/intl (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/form (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/monolog-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/security (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/security-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/swiftmailer-bundle (v3.0.3 => v3.0.4): Downloading (100%)
  - Updating symfony/twig-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/twig-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/translation (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/validator (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/yaml (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/process (v3.3.8 => v3.3.9): Loading from cache
  - Installing composer/semver (1.4.2): Downloading (100%)
  - Updating friendsofphp/php-cs-fixer (v2.5.0 => v2.6.0): Downloading (100%)
  - Updating symfony/var-dumper (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dotenv (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/phpunit-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-profiler-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-server-bundle (v3.3.8 => v3.3.9): Loading from cache
Generating autoload files
```
</details>

  [1]: ba751c7

Commits
-------

0f15099 Update to Symfony 3.3.9 and fix latest changes
sayjun0505 added a commit to sayjun0505/sym_proj that referenced this pull request Apr 16, 2023
@sayjun0505
feature #648 Update to Symfony 3.3.9 and fix latest changes (yceruto)
9b6707f 
This PR was squashed before being merged into the master branch (closes #648).

Discussion
----------

Update to Symfony 3.3.9 and fix latest changes

The [second commit][1] remove the unnecessary configuration for controllers services fixed in symfony/symfony#24126

The third commit update Symfony Flex deps and update `phpunit.xml.dist` env vars according to symfony/recipes#170 and symfony/flex#148

<details>
<summary>See "composer update" log trace.</summary>

```bash
Installing dependencies (including require-dev) from lock file
Package operations: 1 install, 45 updates, 0 removals
  - Updating composer/ca-bundle (1.0.7 => 1.0.8): Downloading (100%)
  - Updating symfony/doctrine-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/stopwatch (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/routing (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/http-foundation (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/event-dispatcher (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/http-kernel (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/flex (v1.0.17 => v1.0.19): Downloading (100%)
  - Updating symfony/finder (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/filesystem (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dependency-injection (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/config (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/class-loader (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/cache (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/framework-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/console (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating doctrine/doctrine-fixtures-bundle (2.3.0 => v2.4.0): Downloading (100%)
  - Updating symfony/asset (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dom-crawler (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/browser-kit (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/css-selector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/expression-language (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/inflector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/property-access (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/options-resolver (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/intl (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/form (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/monolog-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/security (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/security-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/swiftmailer-bundle (v3.0.3 => v3.0.4): Downloading (100%)
  - Updating symfony/twig-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/twig-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/translation (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/validator (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/yaml (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/process (v3.3.8 => v3.3.9): Loading from cache
  - Installing composer/semver (1.4.2): Downloading (100%)
  - Updating friendsofphp/php-cs-fixer (v2.5.0 => v2.6.0): Downloading (100%)
  - Updating symfony/var-dumper (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dotenv (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/phpunit-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-profiler-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-server-bundle (v3.3.8 => v3.3.9): Loading from cache
Generating autoload files
```
</details>

  [1]: symfony/demo@ba751c7

Commits
-------

0f15099 Update to Symfony 3.3.9 and fix latest changes
spider-yamet added a commit to spider-yamet/sym_proj that referenced this pull request Apr 16, 2023
@spider-yamet
feature #648 Update to Symfony 3.3.9 and fix latest changes (yceruto)
28f6f56 
This PR was squashed before being merged into the master branch (closes #648).

Discussion
----------

Update to Symfony 3.3.9 and fix latest changes

The [second commit][1] remove the unnecessary configuration for controllers services fixed in symfony/symfony#24126

The third commit update Symfony Flex deps and update `phpunit.xml.dist` env vars according to symfony/recipes#170 and symfony/flex#148

<details>
<summary>See "composer update" log trace.</summary>

```bash
Installing dependencies (including require-dev) from lock file
Package operations: 1 install, 45 updates, 0 removals
  - Updating composer/ca-bundle (1.0.7 => 1.0.8): Downloading (100%)
  - Updating symfony/doctrine-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/stopwatch (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/routing (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/http-foundation (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/event-dispatcher (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/http-kernel (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/flex (v1.0.17 => v1.0.19): Downloading (100%)
  - Updating symfony/finder (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/filesystem (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dependency-injection (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/config (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/class-loader (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/cache (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/framework-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/console (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating doctrine/doctrine-fixtures-bundle (2.3.0 => v2.4.0): Downloading (100%)
  - Updating symfony/asset (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dom-crawler (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/browser-kit (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/css-selector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/expression-language (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/inflector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/property-access (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/options-resolver (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/intl (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/form (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/monolog-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/security (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/security-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/swiftmailer-bundle (v3.0.3 => v3.0.4): Downloading (100%)
  - Updating symfony/twig-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/twig-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/translation (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/validator (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/yaml (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/process (v3.3.8 => v3.3.9): Loading from cache
  - Installing composer/semver (1.4.2): Downloading (100%)
  - Updating friendsofphp/php-cs-fixer (v2.5.0 => v2.6.0): Downloading (100%)
  - Updating symfony/var-dumper (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dotenv (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/phpunit-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-profiler-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-server-bundle (v3.3.8 => v3.3.9): Loading from cache
Generating autoload files
```
</details>

  [1]: symfony/demo@ba751c7

Commits
-------

0f15099 Update to Symfony 3.3.9 and fix latest changes
frederickboyd added a commit to frederickboyd/frederickboyd that referenced this pull request May 25, 2025
@frederickboyd
feature #648 Update to Symfony 3.3.9 and fix latest changes (yceruto)
8a8cd86 
This PR was squashed before being merged into the master branch (closes #648).

Discussion
----------

Update to Symfony 3.3.9 and fix latest changes

The [second commit][1] remove the unnecessary configuration for controllers services fixed in symfony/symfony#24126

The third commit update Symfony Flex deps and update `phpunit.xml.dist` env vars according to symfony/recipes#170 and symfony/flex#148

<details>
<summary>See "composer update" log trace.</summary>

```bash
Installing dependencies (including require-dev) from lock file
Package operations: 1 install, 45 updates, 0 removals
  - Updating composer/ca-bundle (1.0.7 => 1.0.8): Downloading (100%)
  - Updating symfony/doctrine-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/stopwatch (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/routing (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/http-foundation (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/event-dispatcher (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/http-kernel (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/flex (v1.0.17 => v1.0.19): Downloading (100%)
  - Updating symfony/finder (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/filesystem (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dependency-injection (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/config (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/class-loader (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/cache (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/framework-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/console (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating doctrine/doctrine-fixtures-bundle (2.3.0 => v2.4.0): Downloading (100%)
  - Updating symfony/asset (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dom-crawler (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/browser-kit (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/css-selector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/expression-language (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/inflector (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/property-access (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/options-resolver (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/intl (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/form (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/monolog-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/security (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/security-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/swiftmailer-bundle (v3.0.3 => v3.0.4): Downloading (100%)
  - Updating symfony/twig-bridge (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/twig-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/translation (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/validator (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/yaml (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/process (v3.3.8 => v3.3.9): Loading from cache
  - Installing composer/semver (1.4.2): Downloading (100%)
  - Updating friendsofphp/php-cs-fixer (v2.5.0 => v2.6.0): Downloading (100%)
  - Updating symfony/var-dumper (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/debug-bundle (v3.3.8 => v3.3.9): Loading from cache
  - Updating symfony/dotenv (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/phpunit-bridge (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-profiler-bundle (v3.3.8 => v3.3.9): Downloading (100%)
  - Updating symfony/web-server-bundle (v3.3.8 => v3.3.9): Loading from cache
Generating autoload files
```
</details>

  [1]: symfony/demo@ba751c7

Commits
-------

0f15099 Update to Symfony 3.3.9 and fix latest changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

@yceruto yceruto yceruto left review comments

@symfony-bot symfony-bot symfony-bot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fabpot @yceruto @nicolas-grekas @xabbuh @symfony-bot
0