[Console] Require PHP 7 for ApplicationTest #23934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest to use an |
ace9db6 to
c131a47
Compare
|
Changes made per request above. Branch rebased. |
chalasr
requested changes
Aug 23, 2017
| @@ -33,6 +33,9 @@ | |||
| use Symfony\Component\Console\Exception\CommandNotFoundException; | |||
| use Symfony\Component\EventDispatcher\EventDispatcher; | |||
|
|
|||
| /** | |||
| * @requires PHP 7 | |||
There was a problem hiding this comment.
Only methods which use PHP7 features should be annotated
There was a problem hiding this comment.
Updated and rebased
c131a47 to
94d55ca
Compare
chalasr
approved these changes
Aug 23, 2017
|
Good catch, thanks @siwinski. |
chalasr
pushed a commit
that referenced
this pull request
Aug 23, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [Console] Require PHP 7 for ApplicationTest | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | <!--highly recommended for new features--> Since [ApplicationTest](https://github.com/symfony/symfony/blob/3.3/src/Symfony/Component/Console/Tests/ApplicationTest.php) uses the `Error` class, this component should require-dev `symfony/polyfill-php70` Commits ------- 94d55ca [Console] Require PHP 7 for ApplicationTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ApplicationTest uses the
Errorclass, this component should require-devsymfony/polyfill-php70