8000 minor #23934 [Console] Require PHP 7 for ApplicationTest (siwinski) · symfony/symfony@7ce0665 · GitHub
[go: up one dir, main page]

Skip to content

Commit 7ce0665

Browse files
author
Robin Chalas
committed
minor #23934 [Console] Require PHP 7 for ApplicationTest (siwinski)
This PR was merged into the 3.3 branch. Discussion ---------- [Console] Require PHP 7 for ApplicationTest | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | <!--highly recommended for new features--> Since [ApplicationTest](https://github.com/symfony/symfony/blob/3.3/src/Symfony/Component/Console/Tests/ApplicationTest.php) uses the `Error` class, this component should require-dev `symfony/polyfill-php70` Commits ------- 94d55ca [Console] Require PHP 7 for ApplicationTest
2 parents 420f089 + 94d55ca commit 7ce0665

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

src/Symfony/Component/Console/Tests/ApplicationTest.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1040,6 +1040,9 @@ public function testRunDispatchesAllEventsWithExceptionInListener()
10401040
$this->assertContains('before.error.after.', $tester->getDisplay());
10411041
}
10421042

1043+
/**
1044+
* @requires PHP 7
1045+
*/
10431046
public function testRunWithError()
10441047
{
10451048
$application = new Application();
@@ -1160,6 +1163,7 @@ public function testErrorIsRethrownIfNotHandledByConsoleErrorEvent()
11601163
}
11611164

11621165
/**
1166+
* @requires PHP 7
11631167
* @expectedException \LogicException
11641168
* @expectedExceptionMessage error
11651169
*/
@@ -1181,6 +1185,9 @@ public function testRunWithErrorAndDispatcher()
11811185
$this->assertContains('before.dym.error.after.', $tester->getDisplay(), 'The PHP Error did not dispached events');
11821186
}
11831187

1188+
/**
1189+
* @requires PHP 7
1190+
*/
11841191
public function testRunDispatchesAllEventsWithError()
11851192
{
11861193
$application = new Application();
@@ -1198,6 +1205,9 @@ public function testRunDispatchesAllEventsWithError()
11981205
$this->assertContains('before.dym.error.after.', $tester->getDisplay(), 'The PHP Error did not dispached events');
11991206
}
12001207

1208+
/**
1209+
* @requires PHP 7
1210+
*/
12011211
public function testRunWithErrorFailingStatusCode()
12021212
{
12031213
$application = new Application();

0 commit comments

Comments
 (0)
0