-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Added support for guards when advancing workflow from a command #23906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b044ffb
Added support for guards when advancing workflow from a command
GDIBass 324c208
Code standards update
GDIBass 8ab59cb
Updated if statement
22b44e2
Changed automatic token generation to throw an exception instead
3a8b2ed
Code standard fixes
2ebc71a
Created new Exception to throw and modified tests
92308b4
Created new Exception to throw and modified tests.
2c9d1e2
Removed newline
49839e3
Ahh, I see. It actually wants a newline!
8f2fa6b
changed exception message
fefc202
newline at end of file
15fd863
Updated Test name and exception name to be more accurate
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
src/Symfony/Component/Workflow/Exception/InvalidTokenConfigurationException.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\Workflow\Exception; | ||
|
||
/** | ||
* Thrown by GuardListener when there is no token set, but guards are placed on a transition. | ||
* | ||
* @author Matt Johnson <matj1985@gmail.com> | ||
*/ | ||
class InvalidTokenConfigurationException extends LogicException implements ExceptionInterface | ||
{ | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,6 +69,18 @@ public function testWithSupportedEventAndAccept() | |
$this->assertTrue($event->isBlocked()); | ||
} | ||
|
||
/** | ||
* @expectedException \Symfony\Component\Workflow\Exception\InvalidTokenConfigurationException | ||
* @expectedExceptionMessage There are no token available for workflow unnamed | ||
*/ | ||
public function testWithNoTokenStorage() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. actually, there is a token storage but no token There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated! |
||
{ | ||
$event = $this->createEvent(); | ||
$this->tokenStorage->setToken(null); | ||
|
||
$this->listener->onTransition($event, 'event_name_a'); | ||
} | ||
|
||
private function createEvent() | ||
{ | ||
$subject = new \stdClass(); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[...] no tokens [...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and the exception message should end with a dot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.