8000 Added support for guards when advancing workflow from a command by GDIBass · Pull Request #23906 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Added support for guards when advancing workflow from a command #23906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 5, 2017
Prev Previous commit
Updated Test name and exception name to be more accurate
  • Loading branch information
GDIBass committed Sep 15, 2017
commit 15fd8631128e9d5dfb61c2cbc59e066bb1a98242
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ private function getVariables(GuardEvent $event)
$token = $this->tokenStorage->getToken();

if (null === $token) {
throw new InvalidTokenConfigurationException(sprintf('There are no token available for workflow %s', $event->getWorkflowName()));
throw new InvalidTokenConfigurationException(sprintf('There are no tokens available for workflow %s.', $event->getWorkflowName()));
}

if (null !== $this->roleHierarchy) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ public function testWithSupportedEventAndAccept()

/**
* @expectedException \Symfony\Component\Workflow\Exception\InvalidTokenConfigurationException
* @expectedExceptionMessage There are no token available for workflow unnamed
* @expectedExceptionMessage There are no tokens available for workflow unnamed.
*/
public function testWithNoTokenStorage()
public function testWithNoTokensInTokenStorage()
{
$event = $this->createEvent();
$this->tokenStorage->setToken(null);
Expand Down
0