10000 Don't display the Symfony debug toolbar when printing the page by javiereguiluz · Pull Request #23460 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Don't display the Symfony debug toolbar when printing the page #23460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Don't display the Symfony debug toolbar when printing the page #23460

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54ad0b8
Don't display the Symfony debug toolbar when printing the page
javiereguiluz Jul 9, 2017
346556a
Removed an unnecessary CSS style
javiereguiluz Jul 10, 2017
eefa821
Removed an unnecessary selector
javiereguiluz Jul 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,3 +527,11 @@
padding: 5px 0;
margin-right: 10px;
}

/***** Media query print: Do not print the Toolbar. *****/
@media print {
.sf-toolbar, .sf-error-toolbar {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.sf-error-toolbar is useless here, as the error toolbar also has the sf-toolbar class

display: none;
visibility: hidden;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason for this if there is already display: none?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was in the original CSS rule ... but you are right and this is no longer needed (Bootstrap v4 doesn't use that either. See https://github.com/twbs/bootstrap/blob/v4-dev/scss/_print.scss)

}
}
0