[DI] Remove irrelevant comment from container #23452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
commented
Jul 8, 2017
| $sc->set('foo', $foo = new \stdClass()); | ||
| $this->assertSame($foo, $sc->get('foo'), '->set() sets a service'); | ||
| $sc->set('._. \\o/', $foo = new \stdClass()); | ||
| $this->assertSame($foo, $sc->get('._. \\o/'), '->set() sets a service'); |
There was a problem hiding this comment.
More or less changed to prove my point. Perhaps should be left out if merged =/
fabpot
approved these changes
Jul 17, 2017
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Jul 17, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [DI] Remove irrelevant comment from container | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes-ish | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Spotted in #22811 Commits ------- 595a225 [DI] Remove irrelevant comment from container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted in #22811