minor #23452 [DI] Remove irrelevant comment from container (ro0NL)

fabpot · fabpot · commit 0100ca145d20 · 2017-07-17T12:28:17.000+02:00
This PR was merged into the 2.7 branch. Discussion ---------- [DI] Remove irrelevant comment from container | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes-ish | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #...  | License | MIT | Doc PR | symfony/symfony-docs#...  Spotted in #22811 Commits ------- 595a225 [DI] Remove irrelevant comment from container
diff --git a/src/Symfony/Component/DependencyInjection/Container.php b/src/Symfony/Component/DependencyInjection/Container.php
@@ -29,16 +29,6 @@
  *
  * Parameter and service keys are case insensitive.
  *
- * A service id can contain lowercased letters, digits, underscores, and dots.
- * Underscores are used to separate words, and dots to group services
- * under namespaces:
- *
- * <ul>
- *   <li>request</li>
- *   <li>mysql_session_storage</li>
- *   <li>symfony.mysql_session_storage</li>
- * </ul>
- *
  * A service can also be defined by creating a method named
  * getXXXService(), where XXX is the camelized version of the id:
  *
diff --git a/src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php b/src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php
@@ -134,8 +134,8 @@ public function testGetServiceIds()
     public function testSet()
     {
         $sc = new Container();
-        $sc->set('foo', $foo = new \stdClass());
-        $this->assertSame($foo, $sc->get('foo'), '->set() sets a service');
+        $sc->set('._. \\o/', $foo = new \stdClass());
+        $this->assertSame($foo, $sc->get('._. \\o/'), '->set() sets a service');
     }
 
     public function testSetWithNullResetTheService()

Original file line number	Diff line number	Diff line change
`@@ -29,16 +29,6 @@`
`29`	`29`	`*`
`30`	`30`	`* Parameter and service keys are case insensitive.`
`31`	`31`	`*`
`32`		`- * A service id can contain lowercased letters, digits, underscores, and dots.`
`33`		`- * Underscores are used to separate words, and dots to group services`
`34`		`- * under namespaces:`
`35`		`- *`
`36`		`- * <ul>`
`37`		`- * <li>request</li>`
`38`		`- * <li>mysql_session_storage</li>`
`39`		`- * <li>symfony.mysql_session_storage</li>`
`40`		`- * </ul>`
`41`		`- *`
`42`	`32`	`* A service can also be defined by creating a method named`
`43`	`33`	`* getXXXService(), where XXX is the camelized version of the id:`
`44`	`34`	`*`
Original file line number	Diff line number	Diff line change
`@@ -134,8 +134,8 @@ public function testGetServiceIds()`
`134`	`134`	`public function testSet()`
`135`	`135`	`{`
`136`	`136`	`$sc = new Container();`
`137`		`- $sc->set('foo', $foo = new \stdClass());`
`138`		`- $this->assertSame($foo, $sc->get('foo'), '->set() sets a service');`
	`137`	`+ $sc->set('._. \\o/', $foo = new \stdClass());`
	`138`	`+ $this->assertSame($foo, $sc->get('._. \\o/'), '->set() sets a service');`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`public function testSetWithNullResetTheService()`