8000 [DependencyInjection] fix method signature by xabbuh · Pull Request #22896 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[DependencyInjection] fix method signature #22896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented May 24, 2017
Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22785
License MIT
Doc PR

To allow FC layers in Symfony 3.4 we need to allow null values in the
interface.

To allow FC layers in Symfony 3.4 we need to allow null values in the
interface.
@ro0NL
Copy link
Contributor
ro0NL commented May 24, 2017

@nicolas-grekas
Copy link
Member

Aren't the failures fixed by #22892? Why is this required?

@xabbuh
Copy link
Member Author
xabbuh commented May 24, 2017

This is nonsense. Sorry, for the noise.

@xabbuh xabbuh closed this May 24, 2017
@xabbuh xabbuh deleted the pr-22785 branch May 24, 2017 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0