[ProxyManager] Add FC layer #22892
Merged
[ProxyManager] Add FC layer #22892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
May 24, 2017
| @@ -82,6 +82,8 @@ DependencyInjection | |||
|
|
|||
| * Autowiring services based on the types they implement is deprecated and won't be supported in version 4.0. Rename (or alias) your services to their FQCN id to make them autowirable. | |||
|
|
|||
| * [BC BREAK] The `NullDumper` class has been made final | |||
There was a problem hiding this comment.
this looks wrong to me. It is not actually final in 3.3
There was a problem hiding this comment.
@final + the BC break means to me that we're considering the class final for real, taking advantage of it. IMHO, it sends the good info to the reader.
nicolas-grekas
added a commit
that referenced
this pull request
May 25, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [ProxyManager] Add FC layer | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | yes - minor | Deprecations? | yes - made a class final | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This makes PRoxyDumper compatible with DumperInterface v4.0. Technically, this is a BC break, but since I really don't expect anyone to extend ProxyDumper, I think we should do it - on 3.3 to close the gap as early as possible. Commits ------- 4aeb6d8 [ProxyManager] Add FC layer
nicolas-grekas
added a commit
that referenced
this pull request
May 25, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [travis] Fix 3/4 cross tests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | needs #22892 | Fixed tickets | - | License | MIT | Doc PR | - I just realized that using 7.0 to run deps=high test prevents loading 4.0 versions of deps. Commits ------- 6311be7 [travis] Fix 3/4 cross tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes PRoxyDumper compatible with DumperInterface v4.0.
Technically, this is a BC break, but since I really don't expect anyone to extend ProxyDumper, I think we should do it - on 3.3 to close the gap as early as possible.