8000 [ProxyManager] Add FC layer by nicolas-grekas · Pull Request #22892 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[ProxyManager] Add FC layer #22892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions UPGRADE-3.3.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ DependencyInjection

* Autowiring services based on the types they implement is deprecated and won't be supported in version 4.0. Rename (or alias) your services to their FQCN id to make them autowirable.

* [BC BREAK] The `NullDumper` class has been made final
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks wrong to me. It is not actually final in 3.3

Copy link
Member Author
@nicolas-grekas nicolas-grekas May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@final + the BC break means to me that we're considering the class final for real, taking advantage of it. IMHO, it sends the good info to the reader.


* [BC BREAK] `_defaults` and `_instanceof` are now reserved service names in Yaml configurations. Please rename any services with that names.

* [BC BREAK] non-numeric keys in methods and constructors arguments have never been supported and are now forbidden. Please remove them if you happen to have one.
Expand Down Expand Up @@ -301,6 +303,11 @@ Process
* Extending `Process::run()`, `Process::mustRun()` and `Process::restart()` is
deprecated and won't be supported in 4.0.

ProxyManager
------------

* [BC BREAK] The `ProxyDumper` class has been made final

Security
--------

Expand Down
5 changes: 5 additions & 0 deletions UPGRADE-4.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,11 @@ Process
* Extending `Process::run()`, `Process::mustRun()` and `Process::restart()` is
not supported anymore.

ProxyManager
------------

* The `ProxyDumper` class has been made final

Security
--------

Expand Down
5 changes: 5 additions & 0 deletions src/Symfony/Bridge/ProxyManager/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
CHANGELOG
=========

3.3.0
-----

* [BC BREAK] The `ProxyDumper` class is now final

2.3.0
-----

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
* Generates dumped PHP code of proxies via reflection.
*
* @author Marco Pivetta <ocramius@gmail.com>
*
* @final since version 3.3
*/
class ProxyDumper implements DumperInterface
{
Expand Down Expand Up @@ -63,7 +65,7 @@ public function isProxyCandidate(Definition $definition)
/**
* {@inheritdoc}
*/
public function getProxyFactoryCode(Definition $definition, $id)
public function getProxyFactoryCode(Definition $definition, $id, $methodName = null)
{
$instantiation = 'return';

Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/DependencyInjection/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ CHANGELOG
will not be supported anymore in 4.0
* deprecated the `DefinitionDecorator` class in favor of `ChildDefinition`
* allow config files to be loaded using a glob pattern
* [BC BREAK] the `NullDumper` class is now final

3.2.0
-----
Expand Down
0