[DI] Fix autowire error for inlined services #22857
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
reviewed
May 22, 2017
| new AnalyzeServiceReferencesPass(), | ||
| new RemoveUnusedDefinitionsPass(), | ||
| )), | ||
| new AutowireExceptionPass($autowirePass), | ||
| new AutowireExceptionPass($autowirePass, $inlinedServicePass), |
There was a problem hiding this comment.
perhaps pass $inlinedServicePass->getInlinedServiceIds() directly?
There was a problem hiding this comment.
I'd love to, but the passes haven't run yet at this point
There was a problem hiding this comment.
the pass did not run yet so this would just return an empty array
ro0NL
reviewed
May 22, 2017
| * | ||
| * @return array Service id strings | ||
| */ | ||
| public function getInlinedServiceIds() |
3020bde to
aeb38f6
Compare
|
Thank you @weaverryan. |
nicolas-grekas
added a commit
that referenced
this pull request
May 23, 2017
This PR was squashed before being merged into the 3.3 branch (closes #22857). Discussion ---------- [DI] Fix autowire error for inlined services | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22848 | License | MIT | Doc PR | n/a The `AutowirePass` defers autowiring exceptions until later so that we don't throw autowiring exceptions for services that are ultimately removed. But, if a service is *inlined*, then it appears to be removed, and so we don't throw the exception. This fixes that. It's an easy fix - but it's a bit ugly. We're adding a bit more "state" to the passes... simply because there is some information that needs to be shared through the compiler process. There might be a better way of doing this in the future (e.g. storing some metadata on the `Compiler`), but this *does* work well. Commits ------- 4bcef3d [DI] Fix autowire error for inlined services
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AutowirePassdefers autowiring exceptions until later so that we don't throw autowiring exceptions for services that are ultimately removed. But, if a service is inlined, then it appears to be removed, and so we don't throw the exception. This fixes that.It's an easy fix - but it's a bit ugly. We're adding a bit more "state" to the passes... simply because there is some information that needs to be shared through the compiler process. There might be a better way of doing this in the future (e.g. storing some metadata on the
Compiler), but this does work well.