[TwigBundle] service workflow.twig_extension should stay public #22699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
May 13, 2017
|
Ah, so it was introduced in 3.2 (without any 👍 |
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
May 13, 2017
…ublic (ogizanagi) This PR was merged into the 3.3-dev branch. Discussion ---------- [TwigBundle] service workflow.twig_extension should stay public | Q | A | ------------- | --- | Branch? | master (3.3) | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A While it's not really required for this service to be public AFAIK, it was not made private when introducing it in 3.2. Which means it should stay public in upper branches. But [since we now default to `public: false`](#22615) in every service config file, it's currently private in 3.3. I had a quick look on commits merged after this PR and didn't find any other similar case. Commits ------- 5d07c6a [TwigBundle] service workflow.twig_extension should stay public
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's not really required for this service to be public AFAIK, it was not made private when introducing it in 3.2. Which means it should stay public in upper branches. But since we now default to
public: falsein every service config file, it's currently private in 3.3.I had a quick look on commits merged after this PR and didn't find any other similar case.