bug #22699 [TwigBundle] service workflow.twig_extension should stay public (ogizanagi)

fabpot · fabpot · commit d975419a6c5e · 2017-05-13T07:11:43.000-07:00
This PR was merged into the 3.3-dev branch. Discussion ---------- [TwigBundle] service workflow.twig_extension should stay public | Q | A | ------------- | --- | Branch? | master (3.3) | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A While it's not really required for this service to be public AFAIK, it was not made private when introducing it in 3.2. Which means it should stay public in upper branches. But [since we now default to `public: false`](#22615) in every service config file, it's currently private in 3.3. I had a quick look on commits merged after this PR and didn't find any other similar case. Commits ------- 5d07c6a [TwigBundle] service workflow.twig_extension should stay public
diff --git a/src/Symfony/Bundle/TwigBundle/Resources/config/twig.xml b/src/Symfony/Bundle/TwigBundle/Resources/config/twig.xml
@@ -115,7 +115,7 @@
             <tag name="translation.extractor" alias="twig" />
         </service>
 
-        <service id="workflow.twig_extension" class="Symfony\Bridge\Twig\Extension\WorkflowExtension">
+        <service id="workflow.twig_extension" class="Symfony\Bridge\Twig\Extension\WorkflowExtension" public="true">
             <argument type="service" id="workflow.registry" />
         </service>
 
