10000 [Console] Add throws PHPDoc in Application::run() by maidmaid · Pull Request #22430 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Add throws PHPDoc in Application::run() #22430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2017
Merged

[Console] Add throws PHPDoc in Application::run() #22430

merged 1 commit into from
Apr 14, 2017

Conversation

maidmaid
Copy link
Contributor
@maidmaid maidmaid commented Apr 13, 2017 •
edited
Loading
Q A
Branch? 2.7
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets /
License MIT
Doc PR /

Same idea than merged #22411.

@maidmaid maidmaid changed the title Add throws PHPDoc in Application::run() [Console] Add throws PHPDoc in Application::run() Apr 13, 2017
xabbuh
xabbuh approved these changes Apr 14, 2017
View reviewed changes
Copy link
Member
@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xabbuh xabbuh added this to the 2.7 milestone Apr 14, 2017
@fabpot
Copy link
Member
fabpot commented Apr 14, 2017

Thank you @maidmaid.

@fabpot fabpot merged commit 28332af into symfony:2.7 Apr 14, 2017
fabpot added a commit that referenced this pull request Apr 14, 2017
@fabpot
minor #22430 [Console] Add throws PHPDoc in Application::run() (maidm…
301bfa4 
…aid)

This PR was merged into the 2.7 branch.

Discussion
----------

[Console] Add throws PHPDoc in Application::run()

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | /
| License       | MIT
| Doc PR        | /

Same idea than merged #22411.

Commits
-------

28332af Add trhows PHPDoc in Application::run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@maidmaid @fabpot @xabbuh
0