8000 [Console] Add @throws PHPDoc in Command::run() by maidmaid · Pull Request #22411 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Add @throws PHPDoc in Command::run() #22411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2017
Merged

[Console] Add @throws PHPDoc in Command::run() #22411

merged 1 commit into from
Apr 13, 2017

Conversation

maidmaid
Copy link
Contributor
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets /
License MIT
Doc PR /

@maidmaid maidmaid changed the base branch from master to 2.7 April 12, 2017 22:22
@maidmaid maidmaid force-pushed the fix-phpdoc-command branch from 7af901e to 7489a14 Compare April 12, 2017 22:55
@nicolas-grekas
Copy link
Member

👍 we do not document "rethrow" (or we would have to virtually add it everywhere)

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Apr 13, 2017
@maidmaid
Copy link
Contributor Author

Some "rethrow" would be useful to document. In this case, we can bypass rethrow with ignoreValidationErrors() method. I think it's relevant to have this info in PHPDoc.

@fabpot
Copy link
Member
fabpot commented Apr 13, 2017

Thank you @maidmaid.
8000

@fabpot fabpot merged commit 7489a14 into symfony:2.7 Apr 13, 2017
fabpot added a commit that referenced this pull request Apr 13, 2017
@fabpot
minor #22411 [Console] Add @throws PHPDoc in Command::run() (maidmaid)
eff4feb 
This PR was merged into the 2.7 branch.

Discussion
----------

[Console] Add @throws PHPDoc in Command::run()

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | /
| License       | MIT
| Doc PR        | /

Commits
-------

7489a14 Add @throws phpdoc
@maidmaid maidmaid deleted the fix-phpdoc-command branch April 13, 2017 15:35
@maidmaid maidmaid mentioned this pull request Apr 13, 2017
Merged
fabpot added a commit that referenced this pull request Apr 14, 2017
@fabpot
minor #22430 [Console] Add throws PHPDoc in Application::run() (maidm…
301bfa4 
…aid)

This PR was merged into the 2.7 branch.

Discussion
----------

[Console] Add throws PHPDoc in Application::run()

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | /
| License       | MIT
| Doc PR        | /

Same idea than merged #22411.

Commits
-------

28332af Add trhows PHPDoc in Application::run
@maidmaid maidmaid restored the fix-phpdoc-command branch May 19, 2017 13:47
@fancyweb fancyweb mentioned this pull request Oct 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Console Status: Needs Review
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@maidmaid @nicolas-grekas @fabpot @carsonbot
0