8000 SCA with Php Inspections (EA Extended) by kalessil · Pull Request #21855 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

SCA with Php Inspections (EA Extended) #21855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2017
Merged

SCA with Php Inspections (EA Extended) #21855

merged 1 commit into from
Mar 4, 2017

Conversation

kalessil
Copy link
Contributor
@kalessil kalessil commented Mar 3, 2017
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@kalessil
Copy link
Contributor Author
kalessil commented Mar 3, 2017

Note: dropped assignments are redundant as default values matches the written values.

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Mar 4, 2017
@nicolas-grekas
Copy link
Member

Thank you @kalessil.

@nicolas-grekas nicolas-grekas merged commit e1773ee into symfony:2.7 Mar 4, 2017
nicolas-grekas added a commit that referenced this pull request Mar 4, 2017
@nicolas-grekas
minor #21855 SCA with Php Inspections (EA Extended) (kalessil)
5898ec2 
This PR was merged into the 2.7 branch.

Discussion
----------

SCA with Php Inspections (EA Extended)

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

e1773ee Static code analysis with Php Inspections (EA Extended): dead code dropped, couple bugs fixed
fabpot
fabpot reviewed Mar 4, 2017
View reviewed changes
src/Symfony/Component/Intl/DateFormatter/DateFormat/TimeZoneTransformer.php
@@ -94,6 +94,6 @@ public static function getEtcTimeZoneId($formattedTimeZone)
return 'Etc/GMT'.($hours !== 0 ? $signal.$hours : '');
}

throw new \InvalidArgumentException('The GMT time zone \'%s\' does not match with the supported formats GMT[+-]HH:MM or GMT[+-]HHMM.');
throw new \InvalidArgumentException(sprintf("The GMT time zone '%s' does not match with the supported formats GMT[+-]HH:MM or GMT[+-]HHMM.", $formattedTimeZone));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using "%s%" in error message instead of '%s'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in fd94048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot left review comments

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@kalessil @nicolas-grekas @fabpot @carsonbot
0