8000 minor #21855 SCA with Php Inspections (EA Extended) (kalessil) · symfony/symfony@5898ec2 · GitHub
[go: up one dir, main page]
Skip to content

Commit 5898ec2

Browse files
nicolas-grekasnicolas-grekas
committed
minor #21855 SCA with Php Inspections (EA Extended) (kalessil)
This PR was merged into the 2.7 branch. Discussion ---------- SCA with Php Inspections (EA Extended) | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- e1773ee Static code analysis with Php Inspections (EA Extended): dead code dropped, couple bugs fixed
2 parents cb12e32 + e1773ee commit 5898ec2

File tree

4 files changed

+2
-4
lines changed

4 files changed

+2
-4
lines changed

‎src/Symfony/Component/Intl/DateFormatter/DateFormat/TimeZoneTransformer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,6 @@ public static function getEtcTimeZoneId($formattedTimeZone)
9494
return 'Etc/GMT'.($hours !== 0 ? $signal.$hours : '');
9595
}
9696

97-
throw new \InvalidArgumentException('The GMT time zone \'%s\' does not match with the supported formats GMT[+-]HH:MM or GMT[+-]HHMM.');
97+
throw new \InvalidArgumentException(sprintf("The GMT time zone '%s' does not match with the supported formats GMT[+-]HH:MM or GMT[+-]HHMM.", $formattedTimeZone));
9898
}
9999
}

‎src/Symfony/Component/Process/Process.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@ public function __construct($commandline, $cwd = null, array $env = null, $input
162162
$this->setTimeout($timeout);
163163
$this->useFileHandles = '\\' === DIRECTORY_SEPARATOR;
164164
$this->pty = false;
165-
$this->enhanceWindowsCompatibility = true;
166165
$this->enhanceSigchildCompatibility = '\\' !== DIRECTORY_SEPARATOR && $this->isSigchildEnabled();
167166
$this->options = array_replace(array('suppress_errors' => true, 'binary_pipes' => true), $options);
168167
}

‎src/Symfony/Component/Security/Http/Firewall/DigestAuthenticationListener.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ public function calculateServerDigest($password, $httpMethod)
206206
} elseif ('auth' === $this->elements['qop']) {
207207
$digest .= ':'.$this->elements['nc'].':'.$this->elements['cnonce'].':'.$this->elements['qop'];
208208
} else {
209-
throw new \InvalidArgumentException('This method does not support a qop: "%s".', $this->elements['qop']);
209+
throw new \InvalidArgumentException(sprintf('This method does not support a qop: "%s".', $this->elements['qop']));
210210
}
211211
$digest .= ':'.$a2Md5;
212212

‎src/Symfony/Component/Translation/Catalogue/AbstractOperation.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ public function __construct(MessageCatalogueInterface $source, MessageCatalogueI
6161
$this->source = $source;
6262
$this->target = $target;
6363
$this->result = new MessageCatalogue($source->getLocale());
64-
$this->domains = null;
6564
$this->messages = array();
6665
}
6766

0 commit comments

Comments
 (0)
0