10000 [Twig Bridge] A simpler way to retrieve flash messages by javiereguiluz · Pull Request #21819 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Twig Bridge] A simpler way to retrieve flash messages #21819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

[Twig Bridge] A simpler way to retrieve flash messages #21819

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8ab885d
[Twig Bridge] A simpler way to retrieve flash messages
javiereguiluz Mar 1, 2017
9d471dc
Added the case for just 1 flash message key
javiereguiluz Mar 1, 2017
e05144d
Fixed code syntax
javiereguiluz Mar 1, 2017
e42bd57
Simplified everything
javiereguiluz Mar 2, 2017
27709f3
Fixes
javiereguiluz Mar 4, 2017
3a0b379
Fixed code and added tests
javiereguiluz Mar 4, 2017
7acb794
Fixed code standard
javiereguiluz Mar 4, 2017
16a794d
Don't use the empty() PHP function
javiereguiluz Mar 23, 2017
c916aee
Fixed the condition
javiereguiluz Mar 23, 2017
20eba3f
Added another condition needed when replacing empty()
javiereguiluz Mar 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added the case for just 1 flash message key
  • Loading branch information
@javiereguiluz
javiereguiluz committed Mar 1, 2017
commit 9d471dcf0572f9686c6c688340118ffc3cefc383
4 changes: 4 additions & 0 deletions src/Symfony/Bridge/Twig/AppVariable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,10 @@ public function getFlashes()
return $session->getFlashBag()->all();
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should cast $types to an array first:

$type = (array) $type;

if (1 === func_num_args()) {
return $session->getFlashBag()->get(func_get_arg(0));
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling this method with a string like "notice" as argument would make this check pass and get('n') to be called

Copy link
Member
@chalasr chalasr Mar 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, @HeahDude commented meanwhile :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way.. offset 0 may not exist :) What about ->get(reset($types))?

Copy link
Contributor
@ro0NL ro0NL Mar 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and it violates the api (more or less) with getFlashes(['notice']) (i'd expect a nested array... but you get a flat one).

edit: yeah.. already pointed out by @stof , but it's now advertised with

app.flashes(['notice']) nested array with type => messages

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ro0NL good catch about the potential non-existent 0 offset. I've added ... || empty($types) condition to return all the flashes in that case.


$flashes = array();
foreach ($session->getFlashBag()->all() as $key => $message) {
if (in_array($key, func_get_args())) {
Expand Down
0