8000 [Twig Bridge] A simpler way to retrieve flash messages by javiereguiluz · Pull Request #21819 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Twig Bridge] A simpler way to retrieve flash messages #21819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Next Next commit
[Twig Bridge] A simpler way to retrieve flash messages
  • Loading branch information
javiereguiluz committed Mar 1, 2017
commit 8ab885d345396ab3294c4eafd1f42a45e604d03e
33 changes: 33 additions & 0 deletions src/Symfony/Bridge/Twig/AppVariable.php
Original file line number Diff line number Diff line change
Expand Up @@ -145,4 +145,37 @@ public function getDebug()

return $this->debug;
}

/**
* Returns some or all the existing flash messages. The method is variadic:
* if no arguments are passed, all flashes are returned; if one or more
* arguments are passed, only the flashes that belong to that category are
* returned; e.g. getFlashes('notice') or getFlashes('notice', 'error').
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we could support array of categories? i.e: getFlashes(['notice', 'error']), sometimes this information is configurable.

*
* @return array
*/
public function getFlashes()
{
try {
$session = $this->getSession();
if (null !== $session && !$session->isStarted()) {
return array();
}
} catch(\RuntimeException $e) {
return array();
}

if (0 === func_num_args()) {
return $session->getFlashBag()->all();
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should cast $types to an array first:

$type = (array) $type;

$flashes = array();
foreach ($session->getFlashBag()->all() as $key => $message) {
if (in_array($key, func_get_args())) {
$flashes[$key][] = $message;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling this method with a string like "notice" as argument would make this check pass and get('n') to be called

Copy link
Member
@chalasr chalasr Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, @HeahDude commented meanwhile :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way.. offset 0 may not exist :) What about ->get(reset($types))?

Copy link
Contributor
@ro0NL ro0NL Mar 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and it violates the api (more or less) with getFlashes(['notice']) (i'd expect a nested array... but you get a flat one).

edit: yeah.. already pointed out by @stof , but it's now advertised with

app.flashes(['notice']) nested array with type => messages

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ro0NL good catch about the potential non-existent 0 offset. I've added ... || empty($types) condition to return all the flashes in that case.


return $flashes;
}
}
0