8000 [VarDumper] fix tests when xdebug is enabled by FrancescoBorzi · Pull Request #20785 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[VarDumper] fix tests when xdebug is enabled #20785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[VarDumper] fix tests when xdebug is enabled #20785

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31f3b4d
[VarDumper] fix tests when xdebug is enabled
FrancescoBorzi Dec 6, 2016
d7f0f44
Improvement of previous commit
FrancescoBorzi Dec 6, 2016
0839af1
Partially reverted previous commit
FrancescoBorzi Dec 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improvement of previous commit
  • Loading branch information
@FrancescoBorzi
FrancescoBorzi committed Dec 6, 2016
commit d7f0f44a24091534e6daea062471d6bb359c6a41
2 changes: 1 addition & 1 deletion src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ class: "Symfony\Component\VarDumper\Tests\Caster\ReflectionCasterTest"
*/
public function testGenerator()
{
if (extension_loaded('xdebug')) {
if (ini_get('xdebug.overload_var_dump') == 2) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry if the previous comment wasn't clear enough :)
this specific test should use extension_loaded as before (and the next check is now fine)

$this->markTestSkipped('xdebug is active');
}

Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/VarDumper/Tests/VarClonerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public function testClone()

public function testJsonCast()
{
if (extension_loaded('xdebug')) {
if (ini_get('xdebug.overload_var_dump') == 2) {
$this->markTestSkipped('xdebug is active');
}

Expand Down
0