[VarDumper] fix tests when xdebug is enabled #20785
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20778 |
| License | MIT |
- Disabled some test cases when xdebug is enabled, see [VarDumper] Tests failing #20778
stof
reviewed
Dec 6, 2016
| @@ -147,6 +147,10 @@ class: "Symfony\Component\VarDumper\Tests\Caster\ReflectionCasterTest" | |||
| */ | |||
| public function testGenerator() | |||
| { | |||
| if (extension_loaded('xdebug')) { | |||
There was a problem hiding this comment.
should be skipped only when xdebug.overload_var_dump is set to 2:
- 0 does not overload var_dump at all
- 1 overloads it only with formatting, which does not break our tests AFAIK
- 2 adds the location to the formatted output.
There was a problem hiding this comment.
This is true, but for the next patch (this one is independent from var_dump)
|
note to mergers: this should go in older branches |
|
@stof done, changed the IF condition |
| @@ -147,6 +147,10 @@ class: "Symfony\Component\VarDumper\Tests\Caster\ReflectionCasterTest" | |||
| */ | |||
| public function testGenerator() | |||
| { | |||
| if (ini_get('xdebug.overload_var_dump') == 2) { | |||
There was a problem hiding this comment.
sorry if the previous comment wasn't clear enough :)
this specific test should use extension_loaded as before (and the next check is now fine)
|
@nicolas-grekas done, thanks @stof can you please answer my question in that other PR? |
|
Thank you @ShinDarth. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 6, 2016
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #20785). Discussion ---------- [VarDumper] fix tests when xdebug is enabled | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20778 | License | MIT - Disabled some test cases when xdebug is enabled, see #20778 Commits ------- 488ebbf [VarDumper] fix tests when xdebug is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.