[HttpKernel] Fix exception when serializing request attributes #20621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd92e9f to
2e404d0
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 24, 2016
…utes (nicolas-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [HttpKernel] Fix exception when serializing request attributes | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? B1D8 | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Serializing request attributes obviously fails easily since once can put anything there (I've just got an "Exception: Serialization of 'Closure' is not allowed"). Yet, we don't need attributes when forging a request to feed the TraceableUrlMatcher in RouterController. Well, technically one could for sure register a listener before the router to add an attribute to the request, then use that in the url matcher. But, it makes no sense. And if it were to have, the profiler is already broken in this respect because in e.g. 3.1, the attribute array that is used here has already been processed by the ValueExporter. So the original values have already been altered. Let's just handle request attributes as all the other collected data: using var dumper. Commits ------- 2e404d0 [HttpKernel] Fix exception when serializing request attributes
nicolas-grekas
added a commit
that referenced
this pull request
Nov 25, 2016
…rController (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [WebProfilerBundle] Dont use request attributes in RouterController | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As spotted in #20621, it makes little sense to use request attributes here, and if it were to have, the current code is broken because the returned values here have already been processed by ValueExporter in RequestDataCollector. Commits ------- 962325a [WebProfilerBundle] Dont use request attributes in RouterController
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serializing request attributes obviously fails easily since once can put anything there (I've just got an "Exception: Serialization of 'Closure' is not allowed").
Yet, we don't need attributes when forging a request to feed the TraceableUrlMatcher in RouterController.
Well, technically one could for sure register a listener before the router to add an attribute to the request, then use that in the url matcher.
But, it makes no sense. And if it were to have, the profiler is already broken in this respect because in e.g. 3.1, the attribute array that is used here has already been processed by the ValueExporter. So the original values have already been altered.
Let's just handle request attributes as all the other collected data: using var dumper.