8000 minor #20622 [WebProfilerBundle] Dont use request attributes in Route… · symfony/symfony@821e7bb · GitHub
[go: up one dir, main page]
Skip to content

Commit 821e7bb

Browse files
nicolas-grekasnicolas-grekas
committed
minor #20622 [WebProfilerBundle] Dont use request attributes in RouterController (nicolas-grekas)
This PR was merged into the 2.7 branch. Discussion ---------- [WebProfilerBundle] Dont use request attributes in RouterContr DF45 oller | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As spotted in #20621, it makes little sense to use request attributes here, and if it were to have, the current code is broken because the returned values here have already been processed by ValueExporter in RequestDataCollector. Commits ------- 962325a [WebProfilerBundle] Dont use request attributes in RouterController
2 parents bbddeec + 962325a commit 821e7bb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎src/Symfony/Bundle/WebProfilerBundle/Controller/RouterController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ private function getTraces(RequestDataCollector $request, $method)
8787
$traceRequest = Request::create(
8888
$request->getPathInfo(),
8989
$request->getRequestServer()->get('REQUEST_METHOD'),
90-
$request->getRequestAttributes()->all(),
90+
array(),
9191
$request->getRequestCookies()->all(),
9292
array(),
9393
$request->getRequestServer()->all()

0 commit comments

Comments
 (0)
0