8000 Tweaked the new firewall config in the security profiler panel by javiereguiluz · Pull Request #20397 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Tweaked the new firewall config in the security profiler panel #20397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2016
Merged

Tweaked the new firewall config in the security profiler panel #20397

merged 1 commit into from
Nov 3, 2016

Conversation

javiereguiluz
Copy link
Member
@javiereguiluz javiereguiluz commented Nov 3, 2016 •
edited
Loading
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

All these options can be null ... so maybe we should take care of that edge case.

Before

before

After

after

@chalasr
Copy link
Member
chalasr commented Nov 3, 2016

👍 Thanks for improving it

@ogizanagi
Copy link
Contributor

👍

Status: Reviewed

@fabpot
Copy link
Member
fabpot commented Nov 3, 2016

Thank you @javiereguiluz.

@fabpot fabpot merged commit cdbbd9d into symfony:master Nov 3, 2016
fabpot added a commit that referenced this pull request Nov 3, 2016
@fabpot
minor #20397 Tweaked the new firewall config in the security profiler…
4459598 
… panel (javiereguiluz)

This PR was merged into the 3.2-dev branch.

Discussion
----------

Tweaked the new firewall config in the security profiler panel

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

All these options can be `null` ... so maybe we should take care of that edge case.

### Before

![before](https://cloud.githubusercontent.com/assets/73419/19962832/cfc1a1ca-a1b9-11e6-852c-4c7e4065eb37.png)

### After

![after](https://cloud.githubusercontent.com/assets/73419/19962835/d2bd113e-a1b9-11e6-92ae-f93d4592473c.png)

Commits
-------

cdbbd9d Tweaked the new firewall config in the security profiler panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@javiereguiluz @chalasr @ogizanagi @fabpot @carsonbot
0