8000 minor #20397 Tweaked the new firewall config in the security profiler… · symfony/symfony@4459598 · GitHub
[go: up one dir, main page]

Skip to content

Commit 4459598

Browse files
committed
minor #20397 Tweaked the new firewall config in the security profiler panel (javiereguiluz)
This PR was merged into the 3.2-dev branch. Discussion ---------- Tweaked the new firewall config in the security profiler panel | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - All these options can be `null` ... so maybe we should take care of that edge case. ### Before ![before](https://cloud.githubusercontent.com/assets/73419/19962832/cfc1a1ca-a1b9-11e6-852c-4c7e4065eb37.png) ### After ![after](https://cloud.githubusercontent.com/assets/73419/19962835/d2bd113e-a1b9-11e6-92ae-f93d4592473c.png) Commits ------- cdbbd9d Tweaked the new firewall config in the security profiler panel
2 parents 31d5fff + cdbbd9d commit 4459598

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

src/Symfony/Bundle/SecurityBundle/Resources/views/Collector/security.html.twig

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@
145145
<span class="label">Allows anonymous</span>
146146
</div>
147147
</div>
148+
148149
{% if collector.firewall.security_enabled %}
149150
<table>
150151
<thead>
@@ -156,38 +157,38 @@
156157
<tbody>
157158
<tr>
158159
<th>provider</th>
159-
<td>{{ collector.firewall.provider }}</td>
160+
<td>{{ collector.firewall.provider ?: '(none)' }}</td>
160161
</tr>
161162
<tr>
162163
<th>context</th>
163-
<td>{{ collector.firewall.context }}</td>
164+
<td>{{ collector.firewall.context ?: '(none)' }}</td>
164165
</tr>
165166
<tr>
166167
<th>entry_point</th>
167-
<td>{{ collector.firewall.entry_point }}</td>
168+
<td>{{ collector.firewall.entry_point ?: '(none)' }}</td>
168169
</tr>
169170
<tr>
170171
<th>user_checker</th>
171-
<td>{{ collector.firewall.user_checker }}</td>
172+
<td>{{ collector.firewall.user_checker ?: '(none)' }}</td>
172173
</tr>
173174
<tr>
174175
<th>access_denied_handler</th>
175-
<td>{{ collector.firewall.access_denied_handler }}</td>
176+
<td>{{ collector.firewall.access_denied_handler ?: '(none)' }}</td>
176177
</tr>
177178
<tr>
178179
<th>access_denied_url</th>
179-
<td>{{ collector.firewall.access_denied_url }}</td>
180+
<td>{{ collector.firewall.access_denied_url ?: '(none)' }}</td>
180181
</tr>
181182
<tr>
182183
<th>listeners</th>
183-
<td>{{ collector.firewall.listeners is empty ? 'none' : profiler_dump(collector.firewall.listeners, maxDepth=1) }}</td>
184+
<td>{{ collector.firewall.listeners is empty ? '(none)' : profiler_dump(collector.firewall.listeners, maxDepth=1) }}</td>
184185
</tr>
185186
</tbody>
186187
</table>
187188
{% endif %}
188189
{% elseif collector.enabled %}
189190
<div class="empty">
190-
<p>There is no firewall.</p>
191+
<p>This request was not covered by any firewall.</p>
191192
</div>
192193
{% endif %}
193194
{% else %}

0 commit comments

Comments
 (0)
0