8000 Code enhancement and cleanup by yceruto · Pull Request #19830 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Code enhancement and cleanup #19830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Code enhancement and cleanup #19830

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b819b6d
CS fixes
yceruto Sep 2, 2016
c1cc147
fixed PHPDoc
yceruto Sep 2, 2016
6d53296
fixed duplicate array key
yceruto Sep 2, 2016
2819eb8
added comment about expression result unused
yceruto Sep 2, 2016
653ba1d
fixed namespace for some expected exception in tests
yceruto Sep 2, 2016
118777a
removed unused local variables
yceruto Sep 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added comment about expression result unused
  • Loading branch information
@yceruto
yceruto committed Sep 2, 2016
commit 2819eb804ad69b52673e368a98f4b666cc74d872
1 change: 1 addition & 0 deletions src/Symfony/Component/HttpFoundation/Tests/ResponseHeaderBagTest.php
9E8B
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ public function testToStringDoesntMessUpHeaders()
$headers->set('Location', 'http://www.symfony.com');
$headers->set('Content-type', 'text/html');

//invoking to __toString method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed as this is just a description of the next line.

(string) $headers;

$allHeaders = $headers->allPreserveCase();
Expand Down
0