8000 Code enhancement and cleanup by yceruto · Pull Request #19830 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Code enhancement and cleanup #19830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Code enhancement and cleanup #19830

wants to merge 6 commits into from

Conversation

yceruto
Copy link
Member
@yceruto yceruto commented Sep 2, 2016 •
edited
Loading
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

nicolas-grekas
nicolas-grekas reviewed Sep 2, 2016
View reviewed changes
src/Symfony/Component/Console/Tests/Helper/HelperSetTest.php
@@ -113,6 +113,8 @@ public function testIteration()
*
* @param string $name
* @param HelperSet $helperset allows a mock to verify a particular helperset set is being added to the Helper
*
* @return \PHPUnit_Framework_MockObject_MockObject
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HelperInterface would be more useful

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not document tests, so the whole phpdoc might be removed.

@yceruto yceruto force-pushed the code-enhancement-cleanup branch from 987404b to 49d8e9f Compare September 2, 2016 21:18
@yceruto yceruto force-pushed the code-enhancement-cleanup branch from 49d8e9f to 428b4aa Compare September 2, 2016 21:39
@nicolas-grekas
Copy link
Member

👍

1 similar comment
@javiereguiluz
Copy link
Member

👍

fabpot
fabpot reviewed Sep 5, 2016
View reviewed changes
src/Symfony/Component/HttpFoundation/JsonResponse.php
* {@inheritdoc}
* Factory method for chainability.
*
* Example:.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra dot here

@yceruto yceruto force-pushed the code-enhancement-cleanup branch from 428b4aa to 118777a Compare September 5, 2016 17:30
@yceruto
Copy link
Member Author
yceruto commented Sep 5, 2016

Fixed @fabpot's comments 👍

@nicolas-grekas
Copy link
Member

Thank you @yceruto.

nicolas-grekas added a commit that referenced this pull request Sep 6, 2016
@nicolas-grekas
minor #19830 Code enhancement and cleanup (yceruto)
39905fd 
This PR was squashed before being merged into the 2.7 branch (closes #19830).

Discussion
----------

Code enhancement and cleanup

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

325da3c Code enhancement and cleanup
@yceruto yceruto deleted the code-enhancement-cleanup branch September 6, 2016 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yceruto @nicolas-grekas @javiereguiluz @fabpot @HeahDude @carsonbot
0