[Console] LockableTrait: change visibility to private #19158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This reminds us that we need an upgrade of the BC policy to tell about traits there :) |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 24, 2016
…abbuh) This PR was merged into the 3.2-dev branch. Discussion ---------- [Console] LockableTrait: change visibility to private | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18471 (comment) | License | MIT | Doc PR | Without this change we force users to expose unnecessary extension points they may not want to provide. Commits ------- eaa3bb0 LockableTrait: change visibility to private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change we force users to expose unnecessary extension points they may not want to provide.