minor #19158 [Console] LockableTrait: change visibility to private (xabbuh)

fabpot · fabpot · commit b10ca1f12043 · 2016-06-24T07:13:12.000+02:00
This PR was merged into the 3.2-dev branch. Discussion ---------- [Console] LockableTrait: change visibility to private | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18471 (comment) | License | MIT | Doc PR | Without this change we force users to expose unnecessary extension points they may not want to provide. Commits ------- eaa3bb0 LockableTrait: change visibility to private
diff --git a/src/Symfony/Component/Console/Command/LockableTrait.php b/src/Symfony/Component/Console/Command/LockableTrait.php
@@ -22,14 +22,14 @@
  */
 trait LockableTrait
 {
-    protected $lockHandler;
+    private $lockHandler;
 
     /**
      * Locks a command.
      *
      * @return bool
      */
-    protected function lock($name = null, $blocking = false)
+    private function lock($name = null, $blocking = false)
     {
         if (!class_exists(LockHandler::class)) {
             throw new RuntimeException('To enable the locking feature you must install the symfony/filesystem component.');
@@ -53,7 +53,7 @@ protected function lock($name = null, $blocking = false)
     /**
      * Releases the command lock if there is one.
      */
-    protected function release()
+    private function release()
     {
         if ($this->lockHandler) {
             $this->lockHandler->release();

Original file line number	Diff line number	Diff line change
`@@ -22,14 +22,14 @@`
`22`	`22`	`*/`
`23`	`23`	`trait LockableTrait`
`24`	`24`	`{`
`25`		`- protected $lockHandler;`
	`25`	`+ private $lockHandler;`
`26`	`26`
`27`	`27`	`/**`
`28`	`28`	`* Locks a command.`
`29`	`29`	`*`
`30`	`30`	`* @return bool`
`31`	`31`	`*/`
`32`		`- protected function lock($name = null, $blocking = false)`
	`32`	`+ private function lock($name = null, $blocking = false)`
`33`	`33`	`{`
`34`	`34`	`if (!class_exists(LockHandler::class)) {`
`35`	`35`	`throw new RuntimeException('To enable the locking feature you must install the symfony/filesystem component.');`
`@@ -53,7 +53,7 @@ protected function lock($name = null, $blocking = false)`
`53`	`53`	`/**`
`54`	`54`	`* Releases the command lock if there is one.`
`55`	`55`	`*/`
`56`		`- protected function release()`
	`56`	`+ private function release()`
`57`	`57`	`{`
`58`	`58`	`if ($this->lockHandler) {`
`59`	`59`	`$this->lockHandler->release();`