[Console] remove BC breaking argument #19072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18999 (comment) |
| License | MIT |
| Doc PR |
|
👍 Good catch, thank you @xabbuh. It's even better to don't have it as a real argument. |
| if (func_num_args() > 0) { | ||
| $triggerDeprecationError = func_get_arg(0); | ||
| } | ||
|
|
||
| if ($triggerDeprecationError) { |
There was a problem hiding this comment.
what about: if (0 < func_num_args() && func_get_arg(0)) {
There was a problem hiding this comment.
I guess you mean 0 === func_num_args() || func_get_arg(0)?
|
👍 |
| { | ||
| if ($triggerDeprecationError) { | ||
| if (0 === func_num_args() || func_get_arg(0)) { | ||
| @trigger_error(sprintf('The %s() method is deprecated since version 3.2 and will be removed in 4.0. Use %s:getStream() instead.', __METHOD__, StreamableInputInterface::class), E_USER_DEPRECATED); |
There was a problem hiding this comment.
Should be %s::getStream(), isn't it? (double colon)
There was a problem hiding this comment.
Sorry... @xabbuh Can you please BTW fix it?
There was a problem hiding this comment.
Same typo on the setter... I will open a PR.
There was a problem hiding this comment.
@chalasr Sorry, I missed that comment. Thank you for creating the PR.
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 16, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [Console] remove BC breaking argument | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18999 (comment) | License | MIT | Doc PR | Commits ------- f574330 remove BC breaking argument
nicolas-grekas
added a commit
that referenced
this pull request
Jun 16, 2016
…warning (chalasr) This PR was merged into the 3.2-dev branch. Discussion ---------- Fix the missing colon in get/setInputStream deprecation warning | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19072 (comment) | License | MIT | Doc PR | ~ Commits ------- 0d6dc8e Fix the missing colon in get/setInputStream deprecation warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.