minor #19072 [Console] remove BC breaking argument (xabbuh)

nicolas-grekas · nicolas-grekas · commit 000595867a7a · 2016-06-16T11:20:08.000+02:00
This PR was merged into the 3.2-dev branch. Discussion ---------- [Console] remove BC breaking argument | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18999 (comment) | License | MIT | Doc PR | Commits ------- f574330 remove BC breaking argument
diff --git a/src/Symfony/Component/Console/Helper/QuestionHelper.php b/src/Symfony/Component/Console/Helper/QuestionHelper.php
@@ -99,9 +99,9 @@ public function setInputStream($stream)
      *
      * @return resource
      */
-    public function getInputStream($triggerDeprecationError = true)
+    public function getInputStream()
     {
-        if ($triggerDeprecationError) {
+        if (0 === func_num_args() || func_get_arg(0)) {
             @trigger_error(sprintf('The %s() method is deprecated since version 3.2 and will be removed in 4.0. Use %s:getStream() instead.', __METHOD__, StreamableInputInterface::class), E_USER_DEPRECATED);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -99,9 +99,9 @@ public function setInputStream($stream)`
`99`	`99`	`*`
`100`	`100`	`* @return resource`
`101`	`101`	`*/`
`102`		`- public function getInputStream($triggerDeprecationError = true)`
	`102`	`+ public function getInputStream()`
`103`	`103`	`{`
`104`		`- if ($triggerDeprecationError) {`
	`104`	`+ if (0 === func_num_args() \|\| func_get_arg(0)) {`
`105`	`105`	`@trigger_error(sprintf('The %s() method is deprecated since version 3.2 and will be removed in 4.0. Use %s:getStream() instead.', __METHOD__, StreamableInputInterface::class), E_USER_DEPRECATED);`
`106`	`106`	`}`
`107`	`107`