[Console] SymfonyStyle: Align multi-line/very-long-line blocks#18879
Closed
chalasr wants to merge 1 commit intosymfony:masterfrom
Closed
[Console] SymfonyStyle: Align multi-line/very-long-line blocks#18879chalasr wants to merge 1 commit intosymfony:masterfrom
chalasr wants to merge 1 commit intosymfony:masterfrom
Conversation
Remove SymfonyStyle::comment() changes (out of scope) CS Fixes Add tests
Member
Author
|
My first intention was to propose this on 2.8, it's a mistake... |
Member
|
@chalasr thanks for this PR. In my opinion this is a bug fix which should be merged in 2.7. The "new" behavior is the one we expected since the beginning. |
Member
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
May 26, 2016
…ocks (chalasr) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #18879). Discussion ---------- [Console] SymfonyStyle: Align multi-line/very-long-line blocks | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18564 | License | MIT | Doc PR | n/a This PR makes all lines aligned in multi-line blocks. Very-long-line block: ```php SymfonyStyle::warning('Lorem ipsum...'); ``` Before:  After:  Multi-line block: ```php SymfonyStyle::success(['Lorem ipsum...', 'Lorem ipsum...', 'Lorem ipsum...']); ``` Before:  After:  Also @javiereguiluz pointed the case of `SymfonyStyle::comment()` in #18564, I needed to make it calling `SymfonyStyle::block()` with ` // ` as prefix to fit the first intention of this one. So if this one is merged I'll propose the changes for comments in a second PR (out of this scope). Commits ------- 963fe1d [Console] SymfonyStyle: Align multi-line/very-long-line blocks
Merged
Member
Author
|
@javiereguiluz Do you know if there is a reason for that the 2.7 branch doesn't have the |
Member
|
@chalasr yes I know the reason well 😁 It was my mistake. At first there wasn't a |
Member
Author
|
Hmm ok so I'll keep it on 2.8 (stop me if I'm wrong). |
|
|
||
| public function testLongWordsBlockWrapping() | ||
| { | ||
| $word = 'Lopadotemachoselachogaleokranioleipsanodrimhypotrimmatosilphioparaomelitokatakechymenokichlepikossyphophattoperisteralektryonoptekephalliokigklopeleiolagoiosiraiobaphetraganopterygon'; |
Contributor
There was a problem hiding this comment.
As we discussed, this change should not have been necessary for the test to pass. So I suggest to see #18896
Member
Author
There was a problem hiding this comment.
Thank's for having made the change @ogizanagi
This was referenced Jun 6, 2016
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Jun 8, 2016
… to directly test output (ogizanagi) This PR was merged into the 2.7 branch. Discussion ---------- [Console] [SymfonyStyle] Replace long word wrapping test to directly test output | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18879 (comment) | License | MIT | Doc PR | - This [line](https://github.com/symfony/symfony/pull/18879/files#diff-d3625f2548a3b329058ca5a0f5aa57feR60) should not have been changed in order to the test to pass. I assume the test was flawed at first, so I suggest to simply test the output as we did for other ones. Ping @chalasr Commits ------- b78fff4 [Console] [SymfonyStyle] Replace long word wrapping test to directly test output
symfony-splitter
pushed a commit
to symfony/console
that referenced
this pull request
Jun 8, 2016
… to directly test output (ogizanagi) This PR was merged into the 2.7 branch. Discussion ---------- [Console] [SymfonyStyle] Replace long word wrapping test to directly test output | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#18879 (comment) | License | MIT | Doc PR | - This [line](https://github.com/symfony/symfony/pull/18879/files#diff-d3625f2548a3b329058ca5a0f5aa57feR60) should not have been changed in order to the test to pass. I assume the test was flawed at first, so I suggest to simply test the output as we did for other ones. Ping @chalasr Commits ------- b78fff4 [Console] [SymfonyStyle] Replace long word wrapping test to directly test output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes all lines aligned in multi-line blocks.
Very-long-line block:
Before:
After:
Multi-line block:
Before:
After:
Also @javiereguiluz pointed the case of
SymfonyStyle::comment()in #18564, I needed to make it callingSymfonyStyle::block()with//as prefix to fit the first intention of this one.So if this one is merged I'll propose the changes for comments in a second PR (out of this scope).