[Console] SymfonyStyle: Fix alignment/prefixing of multi-line comments #18889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae5ed5e to
b78b55f
Compare
|
This is the missing part of the recently merged #18879. |
9860fef to
71dfb1f
Compare
|
Are you sure that the failed tests are not related to these changes? |
|
@fabpot You're right, the problem comes from these changes. |
a45cf0f to
36e2ebf
Compare
CS Fixes Add tests Add docblock Fix side effect on FrameworkBundle tests Remove useless '\n' from TextDescriptor since comments are block
36e2ebf to
1c94fea
Compare
|
👍 Status: Reviewed |
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
May 30, 2016
…ine comments (chalasr) This PR was merged into the 2.8 branch. Discussion ---------- [Console] SymfonyStyle: Fix alignment/prefixing of multi-line comments | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Pointed in #18564 (comment). Very-long-line comment: ```php SymfonyStyle::comment('Lorem ipsum ...'); ``` Before:  After:  Multi-line comment: ```php SymfonyStyle::comment(['Lorem ipsum...', 'Lorem ipsum...']); ``` Before:  After:  Commits ------- 1c94fea [Console] SymfonyStyle: Fix alignment/prefixing of multi-line comments
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointed in #18564 (comment).
Very-long-line comment:
Before:
After:
Multi-line comment:
Before:
After:
