[FrameworkBundle] update argument value resolver pass tests #18590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to have at least one assertion per test.
|
Ah that's a good check to have 👍 |
|
Well, I am actually not happy with this particular assertion, but every other assertion that came to my mind made even less sense. |
|
Previously the only assertion was that nothing failed, so this is a better assertion than just that. At least you now check if it didn't get added anyway, despite not existing in the first place. |
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 19, 2016
…sts (xabbuh) This PR was merged into the 3.1-dev branch. Discussion ---------- [FrameworkBundle] update argument value resolver pass tests | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Make sure to have at least one assertion per test. Commits ------- b8afa30 update argument value resolver pass tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to have at least one assertion per test.