8000 Fast multiple setEx with the pipeline transcation (RedisAdapter::doSave) by masterklavi · Pull Request #18248 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fast multiple setEx with the pipeline transcation (RedisAdapter::doSave) #18248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fast multiple setEx with the pipeline transcation (RedisAdapter::doSave) #18248

wants to merge 2 commits into from

Conversation

masterklavi
Copy link
Contributor
Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets -
License MIT
Doc PR -

nicolas-grekas
nicolas-grekas reviewed Mar 21, 2016
View reviewed changes
src/Symfony/Component/Cache/Adapter/RedisAdapter.php
foreach ($serialized as $id => $v) {
$this->redis->expire($id, $lifetime);
if ($lifetime > 0) {
$pipe = $this->redis->multi(Redis::PIPELINE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing \: \Redis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fixed.

@staabm
Copy link
Contributor
staabm commented Mar 21, 2016

did you profile how much faster it is?

@masterklavi
Copy link
Contributor Author

Yes. The new method is faster in ~4 times.

@theofidry
Copy link
Contributor

Is it possible to have a Backfire profile of it?

@nicolas-grekas
Copy link
Member

👍

@masterklavi
Copy link
Contributor Author

Is it possible to have a Backfire profile of it?

5 values: https://blackfire.io/profiles/6a1e8027-1375-4a93-b46e-14ccbc2c639a/graph
100 values: https://blackfire.io/profiles/a4587d2b-c39d-4e54-9d79-d4d90f565c98/graph

100Kb per value:
5 values: https://blackfire.io/profiles/5232a511-a7c3-4cc1-9bb7-6f5b12ef83f1/graph
100 values: https://blackfire.io/profiles/1f7af696-fef9-41b4-8d51-05b12c37fa98/graph

doSave1() is the old method.
doSave2() is the new method.

@stof
Copy link
Member
stof commented Mar 21, 2016

@masterklavi what we would need is a backfire comparison between profiles of the old code and the new code. This would be much easier to analyze than some code running both methods one after the other with different names.

@masterklavi
Copy link
Contributor Author

Ok. https://blackfire.io/profiles/compare/b801ec2e-967b-4961-9b28-f96db157a212/graph

@nicolas-grekas
Co 9E69 py link
Member

Thank you @masterklavi.

@masterklavi masterklavi deleted the redis_dosave branch March 23, 2016 17:37
@fabpot fabpot mentioned this pull request May 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Cache Feature Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@masterklavi @staabm @theofidry @nicolas-grekas @stof @javiereguiluz @carsonbot
0