bug #18248 Fast multiple setEx with the pipeline transcation (RedisAdapter::doSave) (masterklavi)

nicolas-grekas · nicolas-grekas · commit abb8d6486ad8 · 2016-03-23T18:34:09.000+01:00
This PR was squashed before being merged into the 3.1-dev branch (closes #18248). Discussion ---------- Fast multiple setEx with the pipeline transcation (RedisAdapter::doSave) | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- e132763 Fast multiple setEx with the pipeline transcation (RedisAdapter::doSave)
diff --git a/src/Symfony/Component/Cache/Adapter/RedisAdapter.php b/src/Symfony/Component/Cache/Adapter/RedisAdapter.php
@@ -93,22 +93,24 @@ protected function doSave(array $values, $lifetime)
         $serialized = array();
         $failed = array();
 
-        foreach ($values as $id => $v) {
+        foreach ($values as $id => $value) {
             try {
-                $serialized[$id] = serialize($v);
+                $serialized[$id] = serialize($value);
             } catch (\Exception $e) {
                 $failed[] = $id;
             }
         }
 
-        if (!$this->redis->mSet($serialized)) {
-            return false;
-        }
-
-        if ($lifetime >= 1) {
-            foreach ($serialized as $id => $v) {
-                $this->redis->expire($id, $lifetime);
+        if ($lifetime > 0) {
+            $pipe = $this->redis->multi(\Redis::PIPELINE);
+            foreach ($serialized as $id => $value) {
+                $pipe->setEx($id, $lifetime, $value);
             }
+            if (!$pipe->exec()) {
+                return false;
+            }
+        } elseif (!$this->redis->mSet($serialized)) {
+            return false;
         }
 
         return $failed;
